-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rev3 EMP Configs #66
base: master
Are you sure you want to change the base?
Conversation
Add new configs for p1 and p2, leave them to point to Rev2 yaml files for the moment.
This is not ready to merge yet. We might need to make some changes to YAML for any specific differences between Rev3 and Rev2. |
@pwittich I will leave this yaml-format check failure to you. This branch is enough for me to test my emp builds for the time being. We need to decide if there are any changes in the yaml for rev3 that will need applying due to differences between rev2 and rev3 hardware. I'm not aware of any other than the pins at the moment, but pins are handled in emp-fwk for my purposes. |
please get fix from head for #67 |
For the pins I think @rzouCERN has the relevant constraint file |
This should be changed for a dynamic solution at some stage.
8d5df5a
to
b31ee1b
Compare
I already completed the integration of the new pins into EMP. I'm only making changes here required for use with EMP. |
Add new configs for p1 and p2, leave them to point to Rev2 yaml files for the moment.