Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rev3 EMP Configs #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Rev3 EMP Configs #66

wants to merge 2 commits into from

Conversation

furryboffin
Copy link

Add new configs for p1 and p2, leave them to point to Rev2 yaml files for the moment.

Add new configs for p1 and p2, leave them to point to Rev2 yaml files for the moment.
@furryboffin furryboffin linked an issue Nov 29, 2024 that may be closed by this pull request
@furryboffin furryboffin self-assigned this Nov 29, 2024
@furryboffin
Copy link
Author

This is not ready to merge yet. We might need to make some changes to YAML for any specific differences between Rev3 and Rev2.

@furryboffin
Copy link
Author

@pwittich I will leave this yaml-format check failure to you. This branch is enough for me to test my emp builds for the time being.

We need to decide if there are any changes in the yaml for rev3 that will need applying due to differences between rev2 and rev3 hardware. I'm not aware of any other than the pins at the moment, but pins are handled in emp-fwk for my purposes.

@pwittich
Copy link
Contributor

please get fix from head for #67

@pwittich
Copy link
Contributor

@pwittich I will leave this yaml-format check failure to you. This branch is enough for me to test my emp builds for the time being.

We need to decide if there are any changes in the yaml for rev3 that will need applying due to differences between rev2 and rev3 hardware. I'm not aware of any other than the pins at the moment, but pins are handled in emp-fwk for my purposes.

For the pins I think @rzouCERN has the relevant constraint file

This should be changed for a dynamic solution at some stage.
@furryboffin
Copy link
Author

@pwittich I will leave this yaml-format check failure to you. This branch is enough for me to test my emp builds for the time being.
We need to decide if there are any changes in the yaml for rev3 that will need applying due to differences between rev2 and rev3 hardware. I'm not aware of any other than the pins at the moment, but pins are handled in emp-fwk for my purposes.

For the pins I think @rzouCERN has the relevant constraint file

I already completed the integration of the new pins into EMP. I'm only making changes here required for use with EMP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EMP config files for Rev3
2 participants