-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GKE-1.6.0 CIS benchmark #1677
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: rootxrishabh <[email protected]>
Added yamls for OKE
Signed-off-by: rootxrishabh <[email protected]>
Fixed issues with oke cluster testing
Merge Add oke support to Main
This reverts commit 96a8081.
This reverts commit 75ead54.
|
Hi @deboshree-b, just FIY: there is a PR #1672 from last week that is also trying to add GKE 1.6.0 CIS benchmark. |
Recommendation 5.8.1. | ||
scored: false | ||
|
||
- id: 2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no more section 2.2. in GKE 1.6.0: https://workbench.cisecurity.org/benchmarks/16093/sections/2382179
- flag: "permissions" | ||
compare: | ||
op: bitmask | ||
value: "644" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed to 0600
value: "644" | ||
remediation: | | ||
Run the following command (using the config file location identied in the Audit step) | ||
chmod 644 /var/lib/kubelet/config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chmod 600 /var/lib/kubelet/config.yaml
scored: true | ||
|
||
- id: 3.2.7 | ||
text: "Ensure that the --event-qps argument is set to 0 or a level which ensures appropriate event capture (Automated)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the argument is called --eventRecordQPS
and not event-qps
: https://workbench.cisecurity.org/sections/2737106/recommendations/4429347
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's actually the --event-qps
argument as per the kubelet docs: https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/
@@ -278,11 +279,13 @@ version_mapping: | |||
"1.24": "cis-1.24" | |||
"1.25": "cis-1.7" | |||
"1.26": "cis-1.8" | |||
"oke-1.26": "oke-1.26" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems oke-1.26
doesn't relevant GKE-1.6.0, right?
or did i miss something?
@deboshree-b thanks for your contribution! |
The benchmarks are derived using this file
CIS Google Kubernetes Engine (GKE) Benchmark v1.6.0 PDF.pdf