Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GKE-1.6.0 CIS benchmark #1677

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

deboshree-b
Copy link

The benchmarks are derived using this file
CIS Google Kubernetes Engine (GKE) Benchmark v1.6.0 PDF.pdf

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ rootxrishabh
❌ deboshree-b
You have signed the CLA already but the status is still pending? Let us recheck it.

@TastefulToast
Copy link

Hi @deboshree-b, just FIY: there is a PR #1672 from last week that is also trying to add GKE 1.6.0 CIS benchmark.

Recommendation 5.8.1.
scored: false

- id: 2.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no more section 2.2. in GKE 1.6.0: https://workbench.cisecurity.org/benchmarks/16093/sections/2382179

- flag: "permissions"
compare:
op: bitmask
value: "644"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed to 0600

value: "644"
remediation: |
Run the following command (using the config file location identied in the Audit step)
chmod 644 /var/lib/kubelet/config.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chmod 600 /var/lib/kubelet/config.yaml

scored: true

- id: 3.2.7
text: "Ensure that the --event-qps argument is set to 0 or a level which ensures appropriate event capture (Automated)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the argument is called --eventRecordQPS and not event-qps: https://workbench.cisecurity.org/sections/2737106/recommendations/4429347

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's actually the --event-qps argument as per the kubelet docs: https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/

@@ -278,11 +279,13 @@ version_mapping:
"1.24": "cis-1.24"
"1.25": "cis-1.7"
"1.26": "cis-1.8"
"oke-1.26": "oke-1.26"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems oke-1.26 doesn't relevant GKE-1.6.0, right?
or did i miss something?

@afdesk
Copy link
Collaborator

afdesk commented Sep 17, 2024

@deboshree-b thanks for your contribution!
maybe there is a sense to keep the single PR for GKE 1.6.0? - #1672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants