-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GKE-1.6.0 CIS benchmark #1677
Open
deboshree-b
wants to merge
16
commits into
aquasecurity:main
Choose a base branch
from
nirmata:feature/GKE
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2ad0aa1
Added yamls for OKE
rootxrishabh a8dda72
Merge pull request #2 from nirmata/add-oke-support
rootxrishabh 2148409
Crawl paths from ENVs
rootxrishabh a70243f
Fixed typos
rootxrishabh 5414877
Update config.yaml
rootxrishabh 6ed1721
changes made
rootxrishabh 45dfc51
Merge pull request #3 from nirmata/error-testing-oke
rootxrishabh 01ea8f8
Merge pull request #4 from nirmata/add-oke-support
rootxrishabh 75ead54
NDEV-20011 : adding CIS GKE-1.6.0 benchmarks
deboshree-b 96a8081
NDEV-20011 : initial commit for other benchmarks
deboshree-b 2668e26
Revert "NDEV-20011 : initial commit for other benchmarks"
deboshree-b e85614e
Revert "NDEV-20011 : adding CIS GKE-1.6.0 benchmarks"
deboshree-b f55346b
NDEV-20011 : adding gke 1.6.0 benchmark
deboshree-b 1388da7
NDEV-20011 : adding type and test for scored = true benchmarks
deboshree-b 5e7030f
NDEV-20011 : adding gke-1.6.0 in config.yaml
deboshree-b 083b002
NDEV-20011 : updating test for gke 1.6.0 - 4.1.4 benchmark
deboshree-b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
## Version-specific settings that override the values in cfg/config.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
--- | ||
controls: | ||
version: "gke-1.6.0" | ||
id: 2 | ||
text: "Control Plane Configuration" | ||
type: "controlplane" | ||
groups: | ||
- id: 2.1 | ||
text: "Authentication and Authorization" | ||
checks: | ||
- id: 2.1.1 | ||
text: "Client certificate authentication should not be used for users (Automated)" | ||
audit: "kubectl get secrets --namespace kube-system -o json" | ||
remediation: | | ||
Alternative mechanisms provided by Kubernetes such as the use of OIDC should be | ||
implemented in place of client certificates. | ||
You can remediate the availability of client certificates in your GKE cluster. See | ||
Recommendation 5.8.1. | ||
scored: false | ||
|
||
- id: 2.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no more section 2.2. in GKE 1.6.0: https://workbench.cisecurity.org/benchmarks/16093/sections/2382179 |
||
text: "Logging" | ||
type: skip | ||
checks: | ||
- id: 2.2.1 | ||
text: "Ensure that a minimal audit policy is created (Manual)" | ||
type: "manual" | ||
remediation: "This control cannot be modified in GKE." | ||
scored: false | ||
|
||
- id: 2.2.2 | ||
text: "Ensure that the audit policy covers key security concerns (Manual)" | ||
type: "manual" | ||
remediation: "This control cannot be modified in GKE." | ||
scored: false |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems
oke-1.26
doesn't relevant GKE-1.6.0, right?or did i miss something?