Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SaltProc links in software page and dropdown menu #314

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

osanstrong
Copy link
Contributor

Summary of changes

Updates the SaltProc links in the Software dropdown menu and the Software page to reflect the current SaltProc documentation location

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

Copy link
Contributor

@yardasol yardasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change @osanstrong! I'm going to approve, but I think we should wait for @katyhuff's input on one comment before merging.

@@ -49,7 +49,7 @@
dates: 2017-present
role: Andrei Rykhlevskii, original creator and continued contributor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this since Andrei is no longer maintaining SaltProc @katyhuff? That role has shifted to me...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's handle that question separately from this PR.

However, it's worth fixing. Honestly I don't really remember why I have this field. I think it's to note what role the group has in the listed project... but probably it would be better if it listed a current group POC, as you suggest. If that's the case, we'll need to update everything. I don't want to erase history though, maybe we can somehow list two entries: Creator/year (if applicable) and Current POC? What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, having a separate entry for author and a maintainer/point of contact would be good. I'll make an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants