Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SaltProc links in software page and dropdown menu #314

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update SaltProc links in software page and dropdown menu #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _data/navbar.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
- subtitle: "ROLLO"
suburl: "https://gwenchee.github.io/rollo/"
- subtitle: "SaltProc"
suburl: "https://github.com/arfc/saltproc"
suburl: "https://arfc.github.io/saltproc/"

- title: "People"
url: "/people/"
Expand Down
2 changes: 1 addition & 1 deletion _data/projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
dates: 2017-present
role: Andrei Rykhlevskii, original creator and continued contributor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this since Andrei is no longer maintaining SaltProc @katyhuff? That role has shifted to me...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's handle that question separately from this PR.

However, it's worth fixing. Honestly I don't really remember why I have this field. I think it's to note what role the group has in the listed project... but probably it would be better if it listed a current group POC, as you suggest. If that's the case, we'll need to update everything. I don't want to erase history though, maybe we can somehow list two entries: Creator/year (if applicable) and Current POC? What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, having a separate entry for author and a maintainer/point of contact would be good. I'll make an issue for it.

src: https://github.com/arfc/saltproc
url: https://arfc.github.io/software/saltproc
url: https://arfc.github.io/saltproc
description: 'SaltProc is a fuel reprocessing simulation tool for liquid fueled nuclear reactors.'
- name: ROLLO
pic: research/rollo-logo.png
Expand Down