Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lent support #46

Merged
merged 5 commits into from
Aug 14, 2024
Merged

lent support #46

merged 5 commits into from
Aug 14, 2024

Conversation

arnetheduck
Copy link
Owner

lent allows returning a (hidden) pointer to a member thus making Result slightly more efficient when working with types that are expensive to copy.

lent is enabled by default only on recent versions as Nim is known to generate invalid code in earlier releases - how far back lent works reliably depends on where Result appears but versions as recent as 1.6.14 have been known to have issues.

As such, lent support is conservatively enabled only for 2.0.8+ but can be enabled for earlier versoins as well via a compile-time define.

arnetheduck and others added 5 commits August 13, 2024 14:40
`lent` allows returning a (hidden) pointer to a member thus making
Result slightly more efficient when working with types that are
expensive to copy.

`lent` is enabled by default only on recent versions as Nim is known to
generate invalid code in earlier releases - how far back `lent` works
reliably depends on where Result appears but versions as recent as
1.6.14 have been known to have issues.

As such, `lent` support is conservatively enabled only for 2.0.8+ but
can be enabled for earlier versoins as well via a compile-time define.
it's failing all over the place
@arnetheduck arnetheduck merged commit 05e33fa into master Aug 14, 2024
11 checks passed
@arnetheduck arnetheduck deleted the lent branch August 14, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant