[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

agpt8 · 2024-10-02T09:57:16Z

B907: Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear. The check tries to filter out any format specs that are invalid together with !r. If you’re using other conversion flags then e.g. f"'{foo!a}'" can be replaced with f"{ascii(foo)!r}". Not currently implemented for python<3.8 or str.format() calls.

Implement B907 flake8-bugbear rules in Ruff.

Add crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rs to implement B907 rule to replace f"'{foo}'" with f"{foo!r}".
Update crates/ruff_linter/src/rules/flake8_bugbear/mod.rs to include B907 rules.
Add test cases for B907 rules in crates/ruff_linter/src/rules/flake8_bugbear/tests.rs.

Fixes #3758 Implement B903 and B907 flake8-bugbear rules in Ruff. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b903.rs` to implement B903 rule for data classes that only set attributes in an `__init__` method. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rs` to implement B907 rule to replace f"'{foo}'" with f"{foo!r}". * Update `crates/ruff_linter/src/rules/flake8_bugbear/mod.rs` to include B903 and B907 rules. * Add test cases for B903 and B907 rules in `crates/ruff_linter/src/rules/flake8_bugbear/tests.rs`.

* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum

* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`

## Summary fixes: #13603

…collections.abc.AsyncGenerator` (#13611) ## Summary fix #13602 Currently, `UP043` only applies to typing.Generator, but it should also support collections.abc.Generator. This update ensures `UP043` correctly handles both `collections.abc.Generator` and `collections.abc.AsyncGenerator` ### UP043 > `UP043` > Python 3.13 introduced the ability for type parameters to specify default values. As such, the default type arguments for some types in the standard library (e.g., Generator, AsyncGenerator) are now optional. > Omitting type parameters that match the default values can make the code more concise and easier to read. ```py Generator[int, None, None] -> Generator[int] ```

https://github.com/pre-commit/mirrors-prettier has been archived and is no longer maintained. Signed-off-by: Bernát Gábor <[email protected]>

Closes #13545 As described in the issue, we move comments before the inner `if` statement to before the newly constructed `elif` statement (previously `else`).

Resolves #13321. Contents of overlay: ```bash /private/var/folders/v0/l8q3ghks2gs5ns2_p63tyqh40000gq/T/pip-build-env-e0ukpbvo/overlay/bin: total 26M -rwxr-xr-x 1 bgabor8 staff 26M Oct 1 08:22 ruff drwxr-xr-x 3 bgabor8 staff 96 Oct 1 08:22 . drwxr-xr-x 4 bgabor8 staff 128 Oct 1 08:22 .. ``` Python executable: ```bash '/Users/bgabor8/git/github/ruff-find-bin-during-build/.venv/bin/python' ``` PATH is: ```bash ['/private/var/folders/v0/l8q3ghks2gs5ns2_p63tyqh40000gq/T/pip-build-env-e0ukpbvo/overlay/bin', '/private/var/folders/v0/l8q3ghks2gs5ns2_p63tyqh40000gq/T/pip-build-env-e0ukpbvo/normal/bin', '/Library/Frameworks/Python.framework/Versions/3.11/bin', '/Library/Frameworks/Python.framework/Versions/3.12/bin', ``` Not sure where to add tests, there does not seem to be any existing one. Can someone help me with that?

…13601) ## Summary Resolves #9962 by allowing a configuration setting `allowed-unused-imports` TODO: - [x] Figure out the correct name and place for the setting; currently, I have added it top level. - [x] The comparison is pretty naive. I tried using `glob::Pattern` but couldn't get it to work in the configuration. - [x] Add tests - [x] Update documentations ## Test Plan `cargo test`

Closes #13421

dhruvmanila · 2024-10-04T05:46:38Z

FYI, there's another implementation of B903 at #12259

agpt8 · 2024-10-04T05:54:38Z

Thanks @dhruvmanila. I'll remove the B903 implementation and instead create a PR for B907

…13616) Closes #12871 Includes some minor semantic type inference extensions changes to help with reliably detecting integers

## Summary Implements the comparison operator for `[Type::IntLiteral]` and `[Type::BooleanLiteral]` (as an artifact of special handling of `True` and `False` in python). Sets the framework to implement more comparison for types known at static time (e.g. `BooleanLiteral`, `StringLiteral`), allowing us to only implement cases of the triplet `<left> Type`, `<right> Type`, `CmpOp`. Contributes to #12701 (without checking off an item yet). ## Test Plan - Added a test for the comparison of literals that should include most cases of note. - Added a test for the comparison of int instances Please note that the cases do not cover 100% of the branches as there are many and the current testing strategy with variables make this fairly confusing once we have too many in one test. --------- Co-authored-by: Carl Meyer <[email protected]> Co-authored-by: Alex Waygood <[email protected]>

As discussed in #13619

Closes #13343 --------- Co-authored-by: Alex Waygood <[email protected]>

…dlers (#13643)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

## Summary fixes: #13718 ## Test Plan Using the notebook as mentioned in #13718 (comment), this PR does not give the "F821 Undefined name `test_sorted`" diagnostic.

Co-authored-by: Micha Reiser <[email protected]>

Implements inference for `BytesLiteral` comparisons along the lines of #13634. closes #13687 Co-authored-by: Alex Waygood <[email protected]>

…ument pitfalls of using `rstest` in combination with `mdtest` (#13747)

This is a follow-up on #13746: - Use `memmem::find` instead of rolling our own inferior version. - Avoid `x.as_ref()` calls using `&**x`

Fixes #3758 Implement B903 and B907 flake8-bugbear rules in Ruff. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b903.rs` to implement B903 rule for data classes that only set attributes in an `__init__` method. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rs` to implement B907 rule to replace f"'{foo}'" with f"{foo!r}". * Update `crates/ruff_linter/src/rules/flake8_bugbear/mod.rs` to include B903 and B907 rules. * Add test cases for B903 and B907 rules in `crates/ruff_linter/src/rules/flake8_bugbear/tests.rs`.

* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum

* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`

…ent-b903-b907

agpt8 and others added 22 commits October 2, 2024 15:27

Add new rules to Rule enum in codes.rs

cb89963

* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum

0adb25e

Update registry.rs

a8acb23

Update registry.rs

651eab4

Update Rule enum and imports for new rules B903 and B907

399e518

* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`

Rename b903.rs to use_dataclasses_for_data_classes.rs

c812272

Rename b907.rs to f_string_single_quotes.rs

aa8191b

Update mod.rs

d0af490

add missing semicolon

37283a5

change to rule from crate

86dd818

Update codes.rs

b544b41

revert removed comments

9edb711

revert removed comment

6d91f1e

add B907.py and B903.py

2aef2ef

Avoid short circuiting B017 for multiple context managers (#13609)

7e3894f

## Summary fixes: #13603

Move to maintained mirror of prettier (#13592)

fdd0a22

https://github.com/pre-commit/mirrors-prettier has been archived and is no longer maintained. Signed-off-by: Bernát Gábor <[email protected]>

Preserve trivia (i.e. comments) in PLR5501 (#13573)

cc1f766

Closes #13545 As described in the issue, we move comments before the inner `if` statement to before the newly constructed `elif` statement (previously `else`).

Mark FURB118 fix as unsafe (#13613)

99e4566

Closes #13421

dhruvmanila and others added 6 commits October 4, 2024 18:51

Bump version to 0.6.9 (#13624)

975be9c

Fix PTH123 false positive when open is passed a file descriptor (#…

d726f09

…13616) Closes #12871 Includes some minor semantic type inference extensions changes to help with reliably detecting integers

Add test cases for RUF006 with lambdas (#13628)

020f4d4

As discussed in #13619

Mark PLE1141 fix as unsafe (#13629)

2a365bb

Closes #13343 --------- Co-authored-by: Alex Waygood <[email protected]>

[red-knot] Improve tests relating to type inference for exception han…

7c5a7d9

…dlers (#13643)

renovate bot and others added 11 commits October 14, 2024 07:39

Update Rust crate proc-macro2 to v1.0.87 (#13735)

63df94b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency @miniflare/kv to v2.14.4 (#13736)

dd5018a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update Rust crate pathdiff to v0.2.2 (#13734)

58bc981

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update Rust crate clap to v4.5.20 (#13733)

4ef422d

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update Rust crate libcst to v1.5.0 (#13739)

c3a3622

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency @miniflare/storage-memory to v2.14.4 (#13737)

814ab47

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Allow ipytest cell magic (#13745)

5caabe5

## Summary fixes: #13718 ## Test Plan Using the notebook as mentioned in #13718 (comment), this PR does not give the "F821 Undefined name `test_sorted`" diagnostic.

[flake8-todos] Allow words starting with todo (#13640)

9bb4722

Co-authored-by: Micha Reiser <[email protected]>

[red-knot] feat: Inference for BytesLiteral comparisons (#13746)

93097f1

Implements inference for `BytesLiteral` comparisons along the lines of #13634. closes #13687 Co-authored-by: Alex Waygood <[email protected]>

[red-knot] Add a build.rs file to red_knot_python_semantic, and doc…

6048f33

…ument pitfalls of using `rstest` in combination with `mdtest` (#13747)

[red knot] Use memmem::find instead of custom version (#13750)

04b636c

This is a follow-up on #13746: - Use `memmem::find` instead of rolling our own inferior version. - Avoid `x.as_ref()` calls using `&**x`

agpt8 changed the title ~~Implement B903 and B907 flake8-bugbear rules~~ [flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) Oct 14, 2024

agpt8 added 16 commits October 14, 2024 19:40

Add new rules to Rule enum in codes.rs

f0f243a

* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum

a10e61e

Update registry.rs

a9d86c8

Update registry.rs

081b514

Update Rule enum and imports for new rules B903 and B907

1599b25

* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`

Rename b903.rs to use_dataclasses_for_data_classes.rs

cbcba8f

Rename b907.rs to f_string_single_quotes.rs

6c1b1a3

Update mod.rs

549adc9

add missing semicolon

8efe87b

change to rule from crate

4d874bd

Update codes.rs

2b48f4c

revert removed comments

141fc5f

revert removed comment

9241b87

add B907.py and B903.py

ae5a829

Merge remote-tracking branch 'origin/implement-b903-b907' into implem…

7179810

…ent-b903-b907

agpt8 closed this Oct 14, 2024

agpt8 deleted the implement-b903-b907 branch October 14, 2024 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

agpt8 commented Oct 2, 2024 •

edited

Loading

dhruvmanila commented Oct 4, 2024

agpt8 commented Oct 4, 2024

[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

Conversation

agpt8 commented Oct 2, 2024 • edited Loading

dhruvmanila commented Oct 4, 2024

agpt8 commented Oct 4, 2024

agpt8 commented Oct 2, 2024 •

edited

Loading