[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

Fixes #3758 Implement B903 and B907 flake8-bugbear rules in Ruff. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b903.rs` to implement B903 rule for data classes that only set attributes in an `__init__` method. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rs` to implement B907 rule to replace f"'{foo}'" with f"{foo!r}". * Update `crates/ruff_linter/src/rules/flake8_bugbear/mod.rs` to include B903 and B907 rules. * Add test cases for B903 and B907 rules in `crates/ruff_linter/src/rules/flake8_bugbear/tests.rs`.

* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum

* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`

## Summary fixes: #13603

…collections.abc.AsyncGenerator` (#13611) ## Summary fix #13602 Currently, `UP043` only applies to typing.Generator, but it should also support collections.abc.Generator. This update ensures `UP043` correctly handles both `collections.abc.Generator` and `collections.abc.AsyncGenerator` ### UP043 > `UP043` > Python 3.13 introduced the ability for type parameters to specify default values. As such, the default type arguments for some types in the standard library (e.g., Generator, AsyncGenerator) are now optional. > Omitting type parameters that match the default values can make the code more concise and easier to read. ```py Generator[int, None, None] -> Generator[int] ```

https://github.com/pre-commit/mirrors-prettier has been archived and is no longer maintained. Signed-off-by: Bernát Gábor <[email protected]>

Closes #13545 As described in the issue, we move comments before the inner `if` statement to before the newly constructed `elif` statement (previously `else`).

Resolves #13321. Contents of overlay: ```bash /private/var/folders/v0/l8q3ghks2gs5ns2_p63tyqh40000gq/T/pip-build-env-e0ukpbvo/overlay/bin: total 26M -rwxr-xr-x 1 bgabor8 staff 26M Oct 1 08:22 ruff drwxr-xr-x 3 bgabor8 staff 96 Oct 1 08:22 . drwxr-xr-x 4 bgabor8 staff 128 Oct 1 08:22 .. ``` Python executable: ```bash '/Users/bgabor8/git/github/ruff-find-bin-during-build/.venv/bin/python' ``` PATH is: ```bash ['/private/var/folders/v0/l8q3ghks2gs5ns2_p63tyqh40000gq/T/pip-build-env-e0ukpbvo/overlay/bin', '/private/var/folders/v0/l8q3ghks2gs5ns2_p63tyqh40000gq/T/pip-build-env-e0ukpbvo/normal/bin', '/Library/Frameworks/Python.framework/Versions/3.11/bin', '/Library/Frameworks/Python.framework/Versions/3.12/bin', ``` Not sure where to add tests, there does not seem to be any existing one. Can someone help me with that?

…13601) ## Summary Resolves #9962 by allowing a configuration setting `allowed-unused-imports` TODO: - [x] Figure out the correct name and place for the setting; currently, I have added it top level. - [x] The comparison is pretty naive. I tried using `glob::Pattern` but couldn't get it to work in the configuration. - [x] Add tests - [x] Update documentations ## Test Plan `cargo test`

Closes #13421

…13616) Closes #12871 Includes some minor semantic type inference extensions changes to help with reliably detecting integers

## Summary Implements the comparison operator for `[Type::IntLiteral]` and `[Type::BooleanLiteral]` (as an artifact of special handling of `True` and `False` in python). Sets the framework to implement more comparison for types known at static time (e.g. `BooleanLiteral`, `StringLiteral`), allowing us to only implement cases of the triplet `<left> Type`, `<right> Type`, `CmpOp`. Contributes to #12701 (without checking off an item yet). ## Test Plan - Added a test for the comparison of literals that should include most cases of note. - Added a test for the comparison of int instances Please note that the cases do not cover 100% of the branches as there are many and the current testing strategy with variables make this fairly confusing once we have too many in one test. --------- Co-authored-by: Carl Meyer <[email protected]> Co-authored-by: Alex Waygood <[email protected]>

As discussed in #13619

Closes #13343 --------- Co-authored-by: Alex Waygood <[email protected]>

…dlers (#13643)

…sses (#13615)

#13644)

…13634) ## Summary Implements string literal comparisons and fallbacks to `str` instance for `LiteralString`. Completes an item in #13618 ## Test Plan - Adds a dedicated test with non exhaustive cases --------- Co-authored-by: Alex Waygood <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micha Reiser <[email protected]>

Co-authored-by: Micha Reiser <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ter `strict=` to `False` (#13656) Co-authored-by: Alex Waygood <[email protected]>

## Summary Treat async generators as "await" in ASYNC100. Fixes #13637 ## Test Plan Updated snapshot

…security motivations (#13658) Helps with #13614. This docs rewrite draws on the [documentation for the original bandit rule](https://bandit.readthedocs.io/en/latest/plugins/b606_start_process_with_no_shell.html).

…ffix (FURB188)` (#13631)

…f exception classes is caught (#13646)

Part of #13625 See also #13629

Fixed a TODO by adding another TODO. It's the red-knot way! ## Summary `builtins.type` can be subscripted at runtime on Python 3.9+, even though it has no `__class_getitem__` method and its metaclass (which is... itself) has no `__getitem__` method. The special case is [hardcoded directly into `PyObject_GetItem` in CPython](https://github.com/python/cpython/blob/744caa8ef42ab67c6aa20cd691e078721e72e22a/Objects/abstract.c#L181-L184). We just have to replicate the special case in our semantic model. This will fail at runtime on Python <3.9. However, there's a bunch of outstanding questions (detailed in the TODO comment I added) regarding how we deal with subscriptions of other generic types on lower Python versions. Since we want to avoid too many false positives for now, I haven't tried to address this; I've just made `type` subscriptable on all Python versions. ## Test Plan `cargo test -p red_knot_python_semantic --lib`

## Summary Adds a markdown-based test framework for writing tests of type inference and type checking. Fixes #11664. Implements the basic required features. A markdown test file is a suite of tests, each test can contain one or more Python files, with optionally specified path/name. The test writes all files to an in-memory file system, runs red-knot, and matches the resulting diagnostics against `Type: ` and `Error: ` assertions embedded in the Python source as comments. We will want to add features like incremental tests, setting custom configuration for tests, writing non-Python files, testing syntax errors, capturing full diagnostic output, etc. There's also plenty of room for improved UX (colored output?). ## Test Plan Lots of tests! Sample of the current output when a test fails: ``` Running tests/inference.rs (target/debug/deps/inference-7c96590aa84de2a4) running 1 test test inference::path_1_resources_inference_numbers_md ... FAILED failures: ---- inference::path_1_resources_inference_numbers_md stdout ---- inference/numbers.md - Numbers - Floats /src/test.py line 2: unexpected error: [invalid-assignment] "Object of type `Literal["str"]` is not assignable to `int`" thread 'inference::path_1_resources_inference_numbers_md' panicked at crates/red_knot_test/src/lib.rs:60:5: Some tests failed. note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: inference::path_1_resources_inference_numbers_md test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.19s error: test failed, to rerun pass `-p red_knot_test --test inference` ``` --------- Co-authored-by: Micha Reiser <[email protected]> Co-authored-by: Alex Waygood <[email protected]>

…13682)

…tives inside type-parameter lists (#13704)

This adds documentation for the new test framework. I also added documentation for the planned design of features we haven't built yet (clearly marked as such), so that this doc can become the sole source of truth for the test framework design (we don't need to refer back to the original internal design document.) Also fixes a few issues in the test framework implementation that were discovered in writing up the docs. --------- Co-authored-by: T-256 <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Dhruv Manilawala <[email protected]>

## Summary Fixes #13708. Silence `undefined-reveal` diagnostic on any line including a `# revealed:` assertion. Add more context to un-silenced `undefined-reveal` diagnostics in mdtest test failures. This doesn't make the failure output less verbose, but it hopefully clarifies the right fix for an `undefined-reveal` in mdtest, while still making it clear what red-knot's normal diagnostic for this looks like. ## Test Plan Added and updated tests.

Address a potential point of confusion that bit a contributor in #13719 Also remove a no-longer-accurate line about bare `error: ` assertions (which are no longer allowed) and clarify another point about which kinds of error assertions to use.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

## Summary fixes: #13718 ## Test Plan Using the notebook as mentioned in #13718 (comment), this PR does not give the "F821 Undefined name `test_sorted`" diagnostic.

Co-authored-by: Micha Reiser <[email protected]>

Implements inference for `BytesLiteral` comparisons along the lines of #13634. closes #13687 Co-authored-by: Alex Waygood <[email protected]>

…ument pitfalls of using `rstest` in combination with `mdtest` (#13747)

This is a follow-up on #13746: - Use `memmem::find` instead of rolling our own inferior version. - Avoid `x.as_ref()` calls using `&**x`

Fixes #3758 Implement B903 and B907 flake8-bugbear rules in Ruff. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b903.rs` to implement B903 rule for data classes that only set attributes in an `__init__` method. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rs` to implement B907 rule to replace f"'{foo}'" with f"{foo!r}". * Update `crates/ruff_linter/src/rules/flake8_bugbear/mod.rs` to include B903 and B907 rules. * Add test cases for B903 and B907 rules in `crates/ruff_linter/src/rules/flake8_bugbear/tests.rs`.

* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum

* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`

…ent-b903-b907

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

[flake8-bugbear] Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear (B907) #13600

Commits on Oct 2, 2024

Commits on Oct 3, 2024

Commits on Oct 4, 2024

Commits on Oct 5, 2024

Commits on Oct 7, 2024

Commits on Oct 8, 2024

Commits on Oct 9, 2024

Commits on Oct 10, 2024

Commits on Oct 11, 2024

Commits on Oct 13, 2024

Commits on Oct 14, 2024