-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for the search page #541
Conversation
…essary calls to the server
… is smaller than 400 px, to optimize the display on smaller landscape screens
Card view added in latest commits actually quickly hits the limit of deploying with finite number of workers in Gunicorn (as suggested by README) due to its lazy loading of cutouts and lightcurves - as many component update requests actually perform one more request to Solution might be to deploy a number of dedicated workers for |
…ing on the Search link from GET-constructed results page
…an option to limit the number of returned objects there.
…and low quality data points
… web workers. Controlled through LOCALAPI parameter in config file.
With the last commit, the problem of exhaustion of web workers pool should be solved. The commit isolates all API access outside of |
At this point, I consider this PR feature-complete, and ready for review. |
Thanks @karpov-sv ! I started to test all the new features -- it looks super nice! I noticed one big thing though: the switch card/table does not work. If I trigger the button, I get an error from the fact that the endpoint |
Thanks @JulienPeloton for reporting, early morning coding has its downsides :-) I fixed it, should now be working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karpov-sv -- I tried all options, and everything works on my side :-)
Let's merge this!
Redesign of the search page to use "smart search" like in Google or ADS. Like the latter, offer the palette of search terms above the input field.
Possible queries are like:
10 20 300
- cone search at ra=10 dec=20 with 300 arcsec radiusVega r=10
- cone search within 10 arcsec around Vega10 20 300 after="2023-01-01" window=1
- cone search within 300 arcsec from Vega in 24 hours after given momentZTF22abzanvj
- exact search for objectIdZTF23abshpmf r=100
- cone search within 100 arcsec around the alertZTF22abzan
- partial match search for objectIds starting with given patternTRCK_20231212
- partial match search for tracklets (effectively, all tracklets from a given date)class=Unknown
- last 100 alerts of a given classclass=Unknown last=10
- last 10 alerts of a given classclass=Unknown before="2023-01-01 01:12:23"
- last 100 alerts before given momentclass=Anomaly last=10
- last 10 anomaliesafter="2022-12-29 13:36:52" before="2023-12-29 13:46:52"
- date range search with exact specification of start and stop timesEverything is somehow working, except for SSO - this one is waiting for backend API improvements as discussed with Julien.GET api (does anyone actually use it?..) is changed to reflect underlying query parser, so the urls that work now look like:
/?action=conesearch&ra=10&dec=20&r=300
/?action=class&class=Unknown&last=10
Requires installation of two additional packages from pip -
regex
(used for partial matches) anddash-autocomplete-input
(used for dropdown menu for class search).Also requires updating
dash-mantine-components
to latest version from pip.Documentation (mostly the help popup inside the search bar itself) is not yet updated.