Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: past editions page #265

Merged
merged 15 commits into from
Mar 25, 2024
Merged

feat: past editions page #265

merged 15 commits into from
Mar 25, 2024

Conversation

RamGoel
Copy link
Contributor

@RamGoel RamGoel commented Mar 7, 2024

Description
This PR adds a Past Editions page which can hold all the past editions of conference.

For adding a new card to past editions page, just add the URL of archived conference into config/editions.json.

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit a11a944
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/65fd53b9ec03030008b52259
😎 Deploy Preview https://deploy-preview-265--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RamGoel RamGoel changed the title Past Editions Page added feat: past editions page Mar 7, 2024
@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 10, 2024

@thulieblack @Mayaleeeee Please have a look at this PR

@thulieblack
Copy link
Member

image
It looks good, but let's replace the AACoT with AsyncAPI Conf, which might cause confusion with previous years

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 11, 2024

Done, made the change @thulieblack

@thulieblack
Copy link
Member

remove the ones and only leave the year

image

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you

@thulieblack
Copy link
Member

@AceTheCreator please have a final look and merge please

@Mayaleeeee
Copy link
Member

@thulieblack @Mayaleeeee Please have a look at this PR

Well done, @ram.

We can reduce the opacity of the purple background to make it more transparent and lessen the strong purple tone.

Screenshots_2024-03-11-18-40-39.png

@AceTheCreator
Copy link
Member

@RamGoel, I think we should be good to go once you add @Mayaleeeee suggested changes :)

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 12, 2024

hey @Mayaleeeee . Thanks for the feedback. I have made a change. Hopefully it looks good now. Let me know if you need any further change.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 14, 2024

@Mayaleeeee please have a look when you're available.

@AceTheCreator
Copy link
Member

@RamGoel I'd advise you resolve the merge conflict in your PR 🙏🏾

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 15, 2024

@AceTheCreator done!

@AceTheCreator
Copy link
Member

@AceTheCreator done!

Awesome! Let's wait for @Mayaleeeee's review :)

@thulieblack
Copy link
Member

@Mayaleeeee please review

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Mar 20, 2024

Thank you @RamGoel.

  1. Please kindly reduce this font and make it two lines instead of three; for example, Past Events Of (this will be a line), then AsyncAPI Conf will be another line.
    Screenshot 2024-03-20 071640

  2. the cards are too small, and the vertical spacing is way too big compared to the horizontal spacing. Make the cards big, and give them the same vertical and horizontal spacing value.
    Screenshot 2024-03-20 072150

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 20, 2024

sure @Mayaleeeee give me like half an hour. Doing this.

@Mayaleeeee
Copy link
Member

sure @Mayaleeeee give me like half an hour. Doing this.

Alright.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 20, 2024

image
Would you like this type of bg in text @Mayaleeeee . or I keep it as previous one only.

@Mayaleeeee
Copy link
Member

image
Would you like this type of bg in text @Mayaleeeee . or I keep it as previous one only.

I like it. 🥰

But let's reduce the font a little bit.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 20, 2024

Please review it again @Mayaleeeee

@Mayaleeeee
Copy link
Member

Please review it again @Mayaleeeee

Kindly send the image 🙏

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 20, 2024

image

You can check live at this link here

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 21, 2024

@Mayaleeeee please have a look

@Mayaleeeee
Copy link
Member

@Mayaleeeee please have a look

Great work, @RamGoel! We're making progress, but we still need to fix some things. Don't worry, we'll get there together!

  • The letter spacing between the H E R E C O M E S T H E is too much and looks weird; it should be HERE COMES THE

We can also remove it because the sentence Past Editions of AsyncAPI Conf already communicates what we want.

Screenshot 2024-03-21 122647

  • Let's try using the background colour in the image below for the cards; I think it looks better.
    past edition

You can find the image in the Figma link here.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 21, 2024

@Mayaleeeee Busy in something. will do by EOD 22 March IST

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 22, 2024

image

How this looks @Mayaleeeee

@Mayaleeeee
Copy link
Member

image

How this looks @Mayaleeeee

Nice, but let's remove the effect at the end of the card.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 22, 2024

Updated, Please check @Mayaleeeee

image

@Mayaleeeee
Copy link
Member

Updated, Please check @Mayaleeeee

image

Thank you @RamGoel

We can merge now cc @AceTheCreator @thulieblack

@thulieblack
Copy link
Member

Congratulations @RamGoel

@AceTheCreator please merge

@AceTheCreator
Copy link
Member

LTGM!!! Welldone @RamGoel

@AceTheCreator AceTheCreator merged commit e342602 into asyncapi:master Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants