-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: past editions page #265
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@thulieblack @Mayaleeeee Please have a look at this PR |
Done, made the change @thulieblack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you
@AceTheCreator please have a final look and merge please |
Well done, @ram. We can reduce the opacity of the purple background to make it more transparent and lessen the strong purple tone. |
@RamGoel, I think we should be good to go once you add @Mayaleeeee suggested changes :) |
hey @Mayaleeeee . Thanks for the feedback. I have made a change. Hopefully it looks good now. Let me know if you need any further change. |
@Mayaleeeee please have a look when you're available. |
@RamGoel I'd advise you resolve the merge conflict in your PR 🙏🏾 |
@AceTheCreator done! |
Awesome! Let's wait for @Mayaleeeee's review :) |
@Mayaleeeee please review |
Thank you @RamGoel.
|
sure @Mayaleeeee give me like half an hour. Doing this. |
Alright. |
|
I like it. 🥰 But let's reduce the font a little bit. |
Please review it again @Mayaleeeee |
Kindly send the image 🙏 |
You can check live at this link here |
@Mayaleeeee please have a look |
Great work, @RamGoel! We're making progress, but we still need to fix some things. Don't worry, we'll get there together!
We can also remove it because the sentence You can find the image in the Figma link here. |
@Mayaleeeee Busy in something. will do by EOD 22 March IST |
How this looks @Mayaleeeee |
Nice, but let's remove the effect at the end of the card. |
Updated, Please check @Mayaleeeee |
Thank you @RamGoel We can merge now cc @AceTheCreator @thulieblack |
Congratulations @RamGoel @AceTheCreator please merge |
LTGM!!! Welldone @RamGoel |
Description
This PR adds a Past Editions page which can hold all the past editions of conference.
For adding a new card to past editions page, just add the URL of archived conference into
config/editions.json
.