-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch to optional chaining in custom filters and update eslint config #1274
Conversation
Removed Unnecessary character escapes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
please also include the sonarcloud error that this PR target to solve, thanks cc @rishabhr4 |
This PR resolves this issue. |
used optional chain expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove changes from apps/generator/lib/generator.js
as I don't think we have that covered with tests, and some more work will be needed - so yeah, let us not mix the scope, please add separate PR for that
@rishabhr4 please react to failing test run |
This reverts commit 5510150.
updated ecam version so that the failing linting test runs
Quality Gate passedIssues Measures |
Done cc @derberg |
what was the reason for changing eslint config? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot
ok, nevermind I figured it needs an update as old linter did not support optional chaining |
/rtm |
yeah that's why linter tests were failing |
Description
This pull request addresses the issue of unnecessary escape characters in the code.
Changes Made
Removed unnecessary escape characters ($) from the fileName.replace statement: