Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch to optional chaining in custom filters and update eslint config #1274

Merged
merged 4 commits into from
Oct 8, 2024
Merged

refactor: switch to optional chaining in custom filters and update eslint config #1274

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5510150
Update generator.js
rishabhr4 Oct 3, 2024
b9bd819
Update customFilters.js
rishabhr4 Oct 3, 2024
eb86f91
Revert "Update generator.js"
rishabhr4 Oct 8, 2024
44ce244
updated .eslintrc to pass the linting issue
rishabhr4 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/generator/lib/generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ class Generator {
filename = filenamify(filename, { replacement: '-', maxLength: 255 });
}

const newFileName = fileName.replace(`\$\$${template}\$\$`, filename);
const newFileName = fileName.replace(`$$${template}$$`, filename);
const targetFile = path.resolve(this.targetDir, relativeBaseDir, newFileName);
const relativeTargetFile = path.relative(this.targetDir, targetFile);
const shouldOverwriteFile = await this.shouldOverwriteFile(relativeTargetFile);
Expand Down
Loading