Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rewrite to TS and adjust to the v2 ParserJS #141

Merged
merged 9 commits into from
Mar 29, 2023

Conversation

magicmatatjahu
Copy link
Member

Description

  • Rewrite to TS.
  • Adjust exported module to the new v2 ParserJS Custom Schema Parser interface - new validate() function.
  • Improve testing and move to the Jest.
  • Update Readme.
  • Add @magicmatatjahu to the codeowners.

Related issue(s)
Resolves #139

@smoya
Copy link
Member

smoya commented Nov 8, 2022

@fmvilas @jstoiko as code owners, would you mind doing a review to this? Thanks!

smoya
smoya previously approved these changes Nov 8, 2022
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@magicmatatjahu
Copy link
Member Author

@fmvilas Could you create next-major branch? I need it for releasing new major version of parser with v2 ParserJS support.

@fmvilas
Copy link
Member

fmvilas commented Nov 14, 2022

@magicmatatjahu done 👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu changed the base branch from master to next-major November 14, 2022 14:40
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 22, 2023
@smoya
Copy link
Member

smoya commented Mar 29, 2023

not stale

@smoya
Copy link
Member

smoya commented Mar 29, 2023

Please @fmvilas can you merge? I will create a PR later on merging next-major in master.

@fmvilas
Copy link
Member

fmvilas commented Mar 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 33ee9c4 into asyncapi:next-major Mar 29, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move RAML Schema parser (TS version) back from parser-js 2.0 to this repo
4 participants