Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nyxt/submodules #3375

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Delete nyxt/submodules #3375

merged 2 commits into from
Apr 11, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Apr 1, 2024

Description

Thanks to the changes to the *.nix files, adding the element below to {sly,slime}-lisp-implementations

(nyxt-nix-electron
 ("nix-shell"
  ,(expand-file-name "/path/to/shell-electron.nix")
  "--run" "sbcl --dynamic-space-size 3072"))

enables a flexible dev env as exemplified below. Note that it's possible to override libraries marked as git submodules. Concretely ~/common-lisp/cl-lib overrides /path/to/nyxt/checkout/_build/cl-lib, where cl-lib is a dependency featured in .gitmodules. The approach works for both Linux and macOS.

(dolist (system '(:nasdf :nyxt :cl-electron :alexandria)) (print (nth-value 2 (asdf:locate-system system))))
=>
#P"/home/aadcg/common-lisp/nyxt/libraries/nasdf/nasdf.asd" 
#P"/home/aadcg/common-lisp/nyxt/nyxt.asd" 
#P"/home/aadcg/common-lisp/cl-electron/cl-electron.asd" 
#P"/home/aadcg/common-lisp/nyxt/_build/alexandria/alexandria.asd" 

Fixes #3374

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/<renderer>))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg aadcg force-pushed the delete-nyxt/submodules branch 3 times, most recently from 37d345a to bc6652c Compare April 2, 2024 07:14
@aadcg aadcg force-pushed the delete-nyxt/submodules branch from bc6652c to cd88bfb Compare April 9, 2024 13:03
@aadcg aadcg marked this pull request as ready for review April 9, 2024 13:09
@aadcg aadcg assigned aadcg and unassigned aadcg Apr 9, 2024
@aadcg aadcg requested a review from jmercouris April 9, 2024 13:13
aadcg added 2 commits April 11, 2024 10:02
Note that it is possible to override a library available at _build by placing a
different version at ~/common-lisp.
@aadcg aadcg force-pushed the delete-nyxt/submodules branch from cd88bfb to 38bff6b Compare April 11, 2024 07:03
@aadcg aadcg merged commit 38bff6b into master Apr 11, 2024
3 checks passed
@aadcg aadcg deleted the delete-nyxt/submodules branch April 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Delete nyxt/submodules system
1 participant