Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nyxt/submodules #3375

Merged
merged 2 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ it is set to $PREFIX/share/.

NASDF_TESTS_NO_NETWORK disables tests that require networking.

When NYXT_SUBMODULES is "true" (the default), all Lisp dependencies are fetched
as git submodules to the directory set by NASDF_SUBMODULES_DIR. Otherwise, they
need to be made visible to ASDF by other means. In case you have received an
archive that includes the source of these Lisp dependencies, then it all should
work out of the box.
When NYXT_SUBMODULES is "true" (the default), all Lisp dependencies are searched
at ./_build. Otherwise, they need to be made visible to ASDF by other means.
In case you have received an archive that includes the source of these Lisp
dependencies, then it all should work out of the box.

NYXT_RENDERER sets the renderer, by default "gi-gtk".

Expand Down
5 changes: 5 additions & 0 deletions build-scripts/shell-electron.nix
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,10 @@ stdenv.mkDerivation {
pkgs.sqlite.out
pkgs.libressl.out ]};";

shellHook =
''
NYXT_ROOT=`dirname ${toString ../README.org}`;
export CL_SOURCE_REGISTRY=$HOME/common-lisp//:$NYXT_ROOT/_build//:$CL_SOURCE_REGISTRY;
'';

}
7 changes: 7 additions & 0 deletions build-scripts/shell-gi-gtk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,11 @@ stdenv.mkDerivation {

GIO_MODULE_DIR = "${pkgs.glib-networking.out}/lib/gio/modules/";
GIO_EXTRA_MODULES = "${pkgs.glib-networking.out}/lib/gio/modules/";

shellHook =
''
NYXT_ROOT=`dirname ${toString ../README.org}`;
export CL_SOURCE_REGISTRY=$HOME/common-lisp//:$NYXT_ROOT/_build//:$CL_SOURCE_REGISTRY;
'';

}
3 changes: 0 additions & 3 deletions libraries/nasdf/nasdf.asd
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
;;;; SPDX-FileCopyrightText: Atlas Engineer LLC
;;;; SPDX-License-Identifier: BSD-3-Clause

;; Can't depend on CL libraries, because it's in charge of fetching them as git
;; submodules.
(defsystem "nasdf"
:version "0.1.8"
:author "Atlas Engineer LLC"
Expand All @@ -12,6 +10,5 @@
(:file "log")
(:file "nasdf")
(:file "install")
(:file "submodules")
(:file "systems")
(:file "tests")))
17 changes: 1 addition & 16 deletions libraries/nasdf/package.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,7 @@ A test system:
:class :nasdf-test-system
:depends-on (alexandria lisp-unit2)
:components ((:file \"tests\"))
:test-suite-args (:package :my-project/tests))

A system that fetches the Git submodules:

(defsystem \"my-project/submodules\"
:defsystem-depends-on (\"nasdf\")
:class :nasdf-submodule-system)

Shell command to add a submodule to the default directory:

git submodule add https://github.com/atlas-engineer/history-tree _build/history-tree

To update it:

git submodule update --remote _build/history-tree
"))
:test-suite-args (:package :my-project/tests))"))

#+sb-package-locks
(sb-ext:lock-package :nasdf)
4 changes: 0 additions & 4 deletions libraries/nasdf/readme.org
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ installation.

* Features

- Manage CL dependencies as Git submodules, ensuring fine control over their
versions.
- Test suite helpers.
- Installation helpers such as handling of icons or desktop files.

Expand All @@ -17,8 +15,6 @@ See [[file:package.lisp]] for more details.
NASDF exposes the following environment variables for convenience:

- =NASDF_SOURCE_PATH= :: See =nasdf:*dest-source-dir*=.
- =NASDF_SUBMODULES_DIR= :: See =nasdf:*submodules-directory*=.
- =NASDF_SUBMODULES_JOBS= :: See =nasdf:*submodules-jobs*=.
- =NASDF_USE_LOGICAL_PATHS= :: Allow non-expanded logical pathnames in system
pathnames.
This is particularly useful when shipping the source.
Expand Down
74 changes: 0 additions & 74 deletions libraries/nasdf/submodules.lisp

This file was deleted.

6 changes: 5 additions & 1 deletion makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,13 @@ help:

makefile_dir := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))

ifeq ($(NYXT_SUBMODULES),true)
CL_SOURCE_REGISTRY = $(makefile_dir)_build//
export CL_SOURCE_REGISTRY
endif

lisp_eval:=$(LISP) $(LISP_FLAGS) \
--eval '(require "asdf")' \
--eval '(when (string= "$(NYXT_SUBMODULES)" "true") (setf asdf:*default-source-registries* (list (quote asdf/source-registry:environment-source-registry))) (asdf:clear-configuration) (asdf:load-asd "$(makefile_dir)/libraries/nasdf/nasdf.asd") (asdf:load-asd "$(makefile_dir)/nyxt.asd") (asdf:load-system :nyxt/submodules))' \
--eval '(asdf:load-asd "$(makefile_dir)/libraries/nasdf/nasdf.asd")' \
--eval '(asdf:load-asd "$(makefile_dir)/nyxt.asd")' \
--eval
Expand Down
4 changes: 0 additions & 4 deletions nyxt.asd
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,6 @@
(test-op "nyxt/analysis")
(test-op "nyxt/theme"))))

(defsystem "nyxt/submodules"
:defsystem-depends-on ("nasdf")
:class :nasdf-submodule-system)

(defsystem "nyxt/tests"
:defsystem-depends-on ("nasdf")
:class :nasdf-test-system
Expand Down