feat: getting rid of json serialization and near_sdk #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pustovalov
reviewed
Mar 25, 2024
birchmd
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Nice work!
There is clearly a lot of duplicated code here from aurora-engine-sdk, but I understand it must be duplicated because the goal here is to avoid dynamic memory allocation. I wonder if it would be worth-while in the future to refactor aurora-engine-sdk into a more generally reusable library which could be used in as an alternative to near-sdk. Such refactoring could include an alloc feature flag which controls whether to use dynamic allocation or not,
|
@birchmd thanks for your review. Yes. It's a really good point that all this stuff should be moved to the |
raventid
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.