More plotting trace messages #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -410,6 +410,7 @@ impl ClusterPlotter { | |||
| break 'outer; | |||
| } | |||
| ResponseProcessingResult::Continue => { | |||
| trace!("Continue"); | |||
There was a problem hiding this comment.
Please, add some identifiers (Maybe free_instance?) to the log here and in other parts of the match as well as more clear message ("Plotting response result: abort"). It lacks the context now.
There was a problem hiding this comment.
It is already instrumented with farm and sector and there are other messages that are happening right before this, I just need to know the result of process_response_notification function call or rather I was curious if it returned anything or hanged in there.
shamil-gadelshin
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few more things that will help with some really strange cases
Code contributor checklist: