Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More plotting trace messages #2903

Merged
merged 1 commit into from
Jul 10, 2024
Merged

More plotting trace messages #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/subspace-farmer/src/cluster/plotter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ impl ClusterPlotter {
break 'outer;
}
ResponseProcessingResult::Continue => {
trace!("Continue");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add some identifiers (Maybe free_instance?) to the log here and in other parts of the match as well as more clear message ("Plotting response result: abort"). It lacks the context now.

Copy link
Member Author

@nazar-pc nazar-pc Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already instrumented with farm and sector and there are other messages that are happening right before this, I just need to know the result of process_response_notification function call or rather I was curious if it returned anything or hanged in there.

// Nothing to do
}
}
Expand Down
1 change: 1 addition & 0 deletions crates/subspace-farmer/src/single_disk_farm/plotting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ async fn plot_single_sector_internal(
};
let sector_chunk_size = sector_chunk.len() as u64;

trace!(sector_chunk_size, "Writing sector chunk to disk");
let write_fut = task::spawn_blocking({
let plot_file = Arc::clone(plot_file);

Expand Down
Loading