fix(autoware_qp_interface): incorrect parameter passing in delegating constructor #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
NorahXiong
force-pushed
the
porting/fix_bugs/autoware_qp_interface
branch
2 times, most recently
from
b2df0a5 to
25274f6
Compare
|
I will review this after merging #146. |
9 tasks
youtalk
reviewed
Jan 21, 2025
… constructor Signed-off-by: NorahXiong <[email protected]>
NorahXiong
force-pushed
the
porting/fix_bugs/autoware_qp_interface
branch
from
bad0eac to
2a5dcfb
Compare
@youtalk Adapted to the style now. |
youtalk
requested review from
rej55,
maxime-clem,
satoshi-ota,
takayuki5168 and
a team
as code owners
|
Since this is fix PR, I will merge it after CI checks are alright. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
===========================================
- Coverage 78.75% 61.26% -17.50%
===========================================
Files 11 20 +9
Lines 193 759 +566
Branches 73 412 +339
===========================================
+ Hits 152 465 +313
- Misses 11 137 +126
- Partials 30 157 +127
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Class OSQPInterface delegating constructor is misused in the delegator. Variable eps_abs which is always a very tiny value is passed to max_iteration and then segment fault will appear when setting osqp workspace.
Related links
Should be merged after #146.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.