Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix goal_searcher assert #10055

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 31, 2025

Description

fix contaminated rebase miss in #10049

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@soblin soblin marked this pull request as ready for review January 31, 2025 00:19
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 31, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
@soblin soblin enabled auto-merge (squash) January 31, 2025 00:22
@soblin soblin disabled auto-merge January 31, 2025 00:24
@soblin soblin enabled auto-merge (squash) January 31, 2025 00:29
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.84%. Comparing base (461dbc1) to head (a61d3bb).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10055      +/-   ##
==========================================
- Coverage   29.21%   28.84%   -0.37%     
==========================================
  Files        1439     1447       +8     
  Lines      108115   109112     +997     
  Branches    42638    43184     +546     
==========================================
- Hits        31588    31477     -111     
- Misses      73485    74544    +1059     
- Partials     3042     3091      +49     
Flag Coverage Δ *Carryforward flag
differential 0.50% <ø> (?)
total 29.15% <0.00%> (-0.07%) ⬇️ Carriedforward from 461dbc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit ffded51 into autowarefoundation:main Jan 31, 2025
45 of 46 checks passed
@soblin soblin deleted the fix/goal-planner/assert-goal-searcher branch January 31, 2025 00:43
yhisaki pushed a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants