-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_behavior_velocity_traffic_light_module): adjust velocity threshold for ensure stop at yellow light #10064
feat(autoware_behavior_velocity_traffic_light_module): adjust velocity threshold for ensure stop at yellow light #10064
Conversation
…y threshold for ensure stop at yellow light Signed-off-by: tomoya.kimura <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10064 +/- ##
==========================================
- Coverage 28.30% 28.30% -0.01%
==========================================
Files 1484 1486 +2
Lines 111088 111118 +30
Branches 43149 43152 +3
==========================================
+ Hits 31443 31450 +7
- Misses 76625 76648 +23
Partials 3020 3020
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
To address the issue in the traffic_light module where the vehicle abruptly stops the moment the light changes from amber to green without performing a pass judge when the speed is below 2.0 m/s, we will adjust the speed threshold.
At the same time, the threshold for performing pass judge has been parameterized, considering potential requests to adjust it.
Related links
[TIERIV internal link] https://tier4.atlassian.net/browse/RT0-33895
How was this PR tested?
We confirmed an improvement in the sudden deceleration behavior using the rosbag-based logging_simulator, where sudden deceleration had previously been occurring.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
Improvements:
Enables pass judge to be applied even at low speeds (1.0 ~ 2.0 m/s), preventing unnecessary stops when the light changes from amber to green.
Ensures smoother driving and reduces unnecessary braking.
Considerations:
The modified pass judge logic may allow the vehicle to enter the intersection at low speeds.
Changes in stop-and-go behavior could result in different driving patterns compared to the previous implementation.