Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_velocity_traffic_light_module): adjust velocity threshold for ensure stop at yellow light #10064

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Feb 4, 2025

Description

To address the issue in the traffic_light module where the vehicle abruptly stops the moment the light changes from amber to green without performing a pass judge when the speed is below 2.0 m/s, we will adjust the speed threshold.

At the same time, the threshold for performing pass judge has been parameterized, considering potential requests to adjust it.

Related links

[TIERIV internal link] https://tier4.atlassian.net/browse/RT0-33895

How was this PR tested?

We confirmed an improvement in the sudden deceleration behavior using the rosbag-based logging_simulator, where sudden deceleration had previously been occurring.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

Improvements:

Enables pass judge to be applied even at low speeds (1.0 ~ 2.0 m/s), preventing unnecessary stops when the light changes from amber to green.
Ensures smoother driving and reduces unnecessary braking.
Considerations:

The modified pass judge logic may allow the vehicle to enter the intersection at low speeds.
Changes in stop-and-go behavior could result in different driving patterns compared to the previous implementation.

…y threshold for ensure stop at yellow light

Signed-off-by: tomoya.kimura <[email protected]>
@tkimura4 tkimura4 requested a review from TomohitoAndo February 4, 2025 04:50
Copy link

github-actions bot commented Feb 4, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 4, 2025
@tkimura4 tkimura4 marked this pull request as ready for review February 4, 2025 04:59
@tkimura4 tkimura4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (fd7db7b) to head (4417dc1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10064      +/-   ##
==========================================
- Coverage   28.30%   28.30%   -0.01%     
==========================================
  Files        1484     1486       +2     
  Lines      111088   111118      +30     
  Branches    43149    43152       +3     
==========================================
+ Hits        31443    31450       +7     
- Misses      76625    76648      +23     
  Partials     3020     3020              
Flag Coverage Δ *Carryforward flag
differential 10.06% <66.66%> (?)
total 28.30% <ø> (+<0.01%) ⬆️ Carriedforward from fd7db7b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit a98a8f6 into autowarefoundation:main Feb 4, 2025
45 of 46 checks passed
@tkimura4 tkimura4 deleted the feat/change_stop_velocity_threshold branch February 4, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants