Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_run_out_module): fix slow_down jerk filter #10065

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Feb 4, 2025

Description

Fixed an issue where enabling slow_down_limit.enable = true caused the JerkFilter to override and disable the speeds of stop lines other than run_out.

Related links

none

How was this PR tested?

Before:

  • The stop lines generated by stop_line are being overridden by the jerk filter of run_out.
    (This issue can be reproduced by forcibly increasing the speed before a stop line by disabling Autoware Control while driving.)
cap-.2024-12-26-10-48-29.mp4

After:

  • Fixed the issue where existing stop lines were being overridden by the jerk filter of run_out.
    (This issue can be reproduced by forcibly increasing the speed before a stop line by disabling Autoware Control while driving.)
cap-.2024-12-26-10-52-19.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

Fixed a bug where enabling slow_down_limit.enable = true caused stop lines from other avoidance or stop_line modules to be overridden and ignored when run_out was activated.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 4, 2025
@tkimura4 tkimura4 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.31%. Comparing base (4823597) to head (db05d9b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_velocity_run_out_module/src/scene.cpp 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10065      +/-   ##
==========================================
+ Coverage   28.25%   28.31%   +0.06%     
==========================================
  Files        1488     1484       -4     
  Lines      111261   111014     -247     
  Branches    43141    43124      -17     
==========================================
+ Hits        31434    31436       +2     
+ Misses      76623    76558      -65     
+ Partials     3204     3020     -184     
Flag Coverage Δ *Carryforward flag
differential 16.65% <12.50%> (?)
total 28.31% <ø> (+0.06%) ⬆️ Carriedforward from fd7db7b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkimura4 tkimura4 marked this pull request as ready for review February 5, 2025 00:52
@shmpwk shmpwk requested a review from maxime-clem February 5, 2025 00:53
@tkimura4 tkimura4 enabled auto-merge (squash) February 10, 2025 09:54
@tkimura4 tkimura4 merged commit 3c84a57 into autowarefoundation:main Feb 10, 2025
34 checks passed
@tkimura4 tkimura4 deleted the fix/run_out_slow_down branch February 10, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants