Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_ekf_localizer)!: porting from universe to core 2nd #10067

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Feb 4, 2025

Description

Missing autoware_universe_utils porting autowarefoundation/autoware_utils#23, previous PRs were reverted.
We are porting autoware_ekf_localizer to autoware.core, and this PR remove the package from universe

Related links

Parent Issue:

How was this PR tested?

  1. Clone autoware main branch and import source files
  2. Change version on autoware.core(feat(autoware_ekf_localizer)!: porting from universe to core autoware.core#174), autoware_utils(https://github.com/autowarefoundation/autoware_utils/releases/tag/1.1.0) and autoware.universe(this PR) under the "src" dir
  3. Build autoware
  4. Relpay sample rosbag
  5. Confirm the behavior is alright.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Motsu-san Motsu-san changed the title Feat/porting ekf localizer from universe to core feat(autoware_ekf_localizer)!: porting from universe to core 2nd Feb 4, 2025
@Motsu-san Motsu-san force-pushed the feat/porting_ekf_localizer_from_universe_to_core branch from 73c9c21 to 408a9d8 Compare February 4, 2025 22:08
@Motsu-san Motsu-san added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.22%. Comparing base (5e36840) to head (2cf60b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10067      +/-   ##
==========================================
+ Coverage   28.01%   28.22%   +0.20%     
==========================================
  Files        1480     1484       +4     
  Lines      111210   111221      +11     
  Branches    43061    43164     +103     
==========================================
+ Hits        31160    31395     +235     
+ Misses      77043    76723     -320     
- Partials     3007     3103      +96     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 28.29% <ø> (+0.28%) ⬆️ Carriedforward from 87813e7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Motsu-san Motsu-san force-pushed the feat/porting_ekf_localizer_from_universe_to_core branch from 408a9d8 to b460485 Compare February 5, 2025 06:02
@Motsu-san Motsu-san marked this pull request as ready for review February 5, 2025 06:28
@Motsu-san
Copy link
Contributor Author

@meliketanrikulu Could you review the change on localization/autoware_pose_covariance_modifier/README.md again?

Copy link
Contributor

@meliketanrikulu meliketanrikulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro
Copy link
Contributor

@Motsu-san

We should keep autoware-nightly.repos buildable.

Procedure

vcs import src < autoware.repos
vcs import src < simulator.repos
vcs import src < tools.repos
vcs import src < autoware-nightly.repos
MAKEFLAGS="-j2" colcon build \
  --symlink-install \
  --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF \
  --continue-on-error

So, please add

  core/autoware_utils:
    type: git
    url: https://github.com/autowarefoundation/autoware_utils.git
    version: main

to autoware-nightly.repos and make a pull request to autoware.

@Motsu-san
Copy link
Contributor Author

to autoware-nightly.repos and make a pull request to autoware.

@SakodaShintaro Thank you for your review and request. I've forwarded this to the assignee of the related issue.

@Motsu-san Motsu-san force-pushed the feat/porting_ekf_localizer_from_universe_to_core branch from b460485 to 87813e7 Compare February 5, 2025 21:18
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

@SakodaShintaro
Copy link
Contributor

I ran the ndt-ekf-deterministic-test (TIER IV INTERNAL) and it passed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

4 participants