-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_ekf_localizer)!: porting from universe to core 2nd #10067
base: main
Are you sure you want to change the base?
feat(autoware_ekf_localizer)!: porting from universe to core 2nd #10067
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
73c9c21
to
408a9d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10067 +/- ##
==========================================
+ Coverage 28.01% 28.22% +0.20%
==========================================
Files 1480 1484 +4
Lines 111210 111221 +11
Branches 43061 43164 +103
==========================================
+ Hits 31160 31395 +235
+ Misses 77043 76723 -320
- Partials 3007 3103 +96
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
408a9d8
to
b460485
Compare
@meliketanrikulu Could you review the change on localization/autoware_pose_covariance_modifier/README.md again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should keep autoware-nightly.repos buildable. Procedure
So, please add
to autoware-nightly.repos and make a pull request to autoware. |
@SakodaShintaro Thank you for your review and request. I've forwarded this to the assignee of the related issue. |
Signed-off-by: Motsu-san <[email protected]>
Signed-off-by: Motsu-san <[email protected]>
Signed-off-by: Motsu-san <[email protected]>
b460485
to
87813e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm testing with the TIER IV's evaluator as well. |
I ran the ndt-ekf-deterministic-test (TIER IV INTERNAL) and it passed. 👍 |
Description
Missing autoware_universe_utils porting autowarefoundation/autoware_utils#23, previous PRs were reverted.
We are porting autoware_ekf_localizer to autoware.core, and this PR remove the package from universe
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.