-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ekf_localizer, system_error_monitor): system_error_monitor handles ekf diags #5467
feat(ekf_localizer, system_error_monitor): system_error_monitor handles ekf diags #5467
Conversation
Signed-off-by: kminoda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5467 +/- ##
==========================================
- Coverage 15.06% 15.04% -0.02%
==========================================
Files 1662 1662
Lines 115713 115862 +149
Branches 35755 35873 +118
==========================================
Hits 17437 17437
- Misses 78739 78875 +136
- Partials 19537 19550 +13
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <[email protected]>
@ito-san Would you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…es ekf diags (autowarefoundation#5467) * fix(ekf_localizer): change default parameter for no update count Signed-off-by: kminoda <[email protected]> * add ekf in system_error_monitor Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…es ekf diags (autowarefoundation#5467) * fix(ekf_localizer): change default parameter for no update count Signed-off-by: kminoda <[email protected]> * add ekf in system_error_monitor Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Although current emergency handling system for localization solely relies on
localization_accuracy
, the criteria may not be accurate enough given that the covariances of NDT, IMU, and wheel odometry are still under development (e.g. the covariance estimation of NDT is still ongoing, and currently we use a static value that is empirically derived). One alternative criteria that we can use (at least temporarily) is to monitor if the valid NDT results have been published recently. In current Autoware implementation, we can monitor this by checkingno_update_count
inekf_localizer
. That being said, I want to make Autoware Universe ready for using the EKF output for emergency handling.Here are the changes that I would like to propose:
diagnostic_aggregator
no_update_count
, since current value (250, which corresponds to 5[sec] with 50Hz EKF) is too large.Note that this PR itself ONLY affects the safe fault and not for single fault or latent fault which are directly connected to the minimum risk maneuver (MRM). The decision whether to really use this for MRM should depend on each reference designs.
Note that we also need to merge autowarefoundation/autoware_launch#674
Tests performed
Not applicable
Effects on system behavior
No effect expected on current Autoware, since the diagnostic result of EKF is not used in MRM.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.