Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(universe_utils): add Buffer implementation to replace boost.buffer() #9333

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

mraditya01
Copy link
Contributor

@mraditya01 mraditya01 commented Nov 15, 2024

Description

Added new buffer function within universe_utils to replace boost.buffer function on point, multiple points, polygons, and multi polygons. Algorithm based on POLYGON OFFSETTING BY COMPUTING WINDING NUMBERS, Xiaorui Chen Sara McMains, Berkeley, 2005

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 19, 2024
@mraditya01 mraditya01 marked this pull request as ready for review December 20, 2024 06:32
@xmfcx
Copy link
Contributor

xmfcx commented Feb 4, 2025

@mraditya01 could you resolve the conflicts and rebase this PR?

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 81.87500% with 29 lines in your changes missing coverage. Please review.

Project coverage is 28.42%. Comparing base (421d9ec) to head (a0ec4a8).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...oware_universe_utils/src/geometry/polygon_clip.cpp 80.89% 14 Missing and 3 partials ⚠️
...on/autoware_universe_utils/src/geometry/buffer.cpp 83.09% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9333      +/-   ##
==========================================
+ Coverage   28.30%   28.42%   +0.12%     
==========================================
  Files        1485     1486       +1     
  Lines      111091   111251     +160     
  Branches    43152    43220      +68     
==========================================
+ Hits        31445    31628     +183     
+ Misses      76626    76592      -34     
- Partials     3020     3031      +11     
Flag Coverage Δ *Carryforward flag
differential 31.23% <81.87%> (?)
total 28.30% <ø> (ø) Carriedforward from 8c115f7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants