Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_route_handler): fix bugprone-exception-escape #9738

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-exception-escape error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_route_handler/src/route_handler.cpp:1161:38: error: an exception may be thrown in function 'getAllLeftSharedLinestringLanelets' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
lanelet::ConstLanelets RouteHandler::getAllLeftSharedLinestringLanelets(
                                     ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_route_handler/src/route_handler.cpp:1196:38: error: an exception may be thrown in function 'getAllRightSharedLinestringLanelets' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
lanelet::ConstLanelets RouteHandler::getAllRightSharedLinestringLanelets(
                                     ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_route_handler/src/route_handler.cpp:1231:38: error: an exception may be thrown in function 'getAllSharedLineStringLanelets' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
lanelet::ConstLanelets RouteHandler::getAllSharedLineStringLanelets(
                                     ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc December 23, 2024 10:28
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.

Project coverage is 29.73%. Comparing base (e5243e4) to head (f2def94).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
...nning/autoware_route_handler/src/route_handler.cpp 38.09% 22 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9738      +/-   ##
==========================================
- Coverage   29.74%   29.73%   -0.01%     
==========================================
  Files        1443     1447       +4     
  Lines      108681   108716      +35     
  Branches    42663    42683      +20     
==========================================
+ Hits        32330    32331       +1     
- Misses      73172    73206      +34     
  Partials     3179     3179              
Flag Coverage Δ *Carryforward flag
differential 33.46% <38.09%> (?)
total 29.74% <ø> (-0.01%) ⬇️ Carriedforward from 0f708e9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kobayu858 <[email protected]>
@kobayu858 kobayu858 merged commit 4658653 into autowarefoundation:main Dec 24, 2024
33 of 35 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 25, 2024
…oundation#9738)

* fix: bugprone-error

Signed-off-by: kobayu858 <[email protected]>

* fix: add include

Signed-off-by: kobayu858 <[email protected]>

---------

Signed-off-by: kobayu858 <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
…oundation#9738)

* fix: bugprone-error

Signed-off-by: kobayu858 <[email protected]>

* fix: add include

Signed-off-by: kobayu858 <[email protected]>

---------

Signed-off-by: kobayu858 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants