Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sensing, perception): fix universe documentation #9773

Conversation

@technolojin technolojin self-assigned this Dec 25, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review December 25, 2024 03:51
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
Signed-off-by: Taekjin LEE <[email protected]>
@vividf
Copy link
Contributor

vividf commented Dec 25, 2024

@technolojin Hi Lee-San, Thanks for your PR. However, for the sensing one they are fixed in another PR #9765

@vividf
Copy link
Contributor

vividf commented Dec 25, 2024

@technolojin I think also for the perception as well (some of them are overlapped) could we merge that one first? Thanks

Link: #9766

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.71%. Comparing base (421ec7d) to head (e737bae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9773      +/-   ##
==========================================
- Coverage   29.72%   29.71%   -0.01%     
==========================================
  Files        1451     1452       +1     
  Lines      108839   108871      +32     
  Branches    42741    42743       +2     
==========================================
+ Hits        32348    32351       +3     
- Misses      73313    73342      +29     
  Partials     3178     3178              
Flag Coverage Δ *Carryforward flag
differential 23.24% <ø> (?)
differential-cuda 23.24% <ø> (?)
total 29.72% <ø> (ø) Carriedforward from 421ec7d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as draft December 25, 2024 04:15
Copy link
Contributor Author

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some missing default values.

@technolojin
Copy link
Contributor Author

already done #9766 #9765

@technolojin technolojin deleted the fix/perception/universe-documentation branch December 25, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants