Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_planning_evaluator): rename lateral deviation metrics #9801

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Dec 26, 2024

Description

  • Restore metrics accidentally deleted in the PR
  • Add "local" and "lookahead" suffixes to differentiate from similar metrics introduced in the PR

Related links

Parent Issue:

  • Link

How was this PR tested?

run psim and cofirmed both metric value is caluclated with following command

ros2 topic echo /planning/planning_evaluator/metrics | grep lateral_trajectory_displacement_local/mean -A 2
ros2 topic echo /planning/planning_evaluator/metrics | grep lateral_trajectory_displacement_lookahead/mean -A 2
Screencast.from.2024.12.26.15.51.46.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xtk8532704 xtk8532704 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2024
Copy link
Contributor

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the rapid bug fix.

@Kazunori-Nakajima
Copy link
Contributor

Thank you very much!!!

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.76%. Comparing base (ee93be1) to head (bcda424).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9801   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files        1454     1455    +1     
  Lines      109090   109111   +21     
  Branches    42476    42477    +1     
=======================================
+ Hits        31375    31382    +7     
- Misses      74548    74561   +13     
- Partials     3167     3168    +1     
Flag Coverage Δ *Carryforward flag
differential 8.41% <100.00%> (?)
total 28.75% <ø> (-0.01%) ⬇️ Carriedforward from 34e0179

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara merged commit 0997af5 into autowarefoundation:main Dec 26, 2024
36 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the fix/planning_evaluator/revert_metric branch December 26, 2024 07:42
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…utowarefoundation#9801)

* refactor(planning_evaluator): rename and add lateral trajectory displacement metrics

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix typo

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara added a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
…utowarefoundation#9801)

* refactor(planning_evaluator): rename and add lateral trajectory displacement metrics

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix typo

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants