[WIP] feat: apply autoware_ prefix for system_monitor
#9975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note:
* In this commit, I did not organize a folder structure.
The folder structure will be organized in the next some commits.
* The changes will follow the Autoware's guideline as below:
- https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder
Signed-off-by: Junya Sasaki <[email protected]>
github-actions
bot
added
the
component:system
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…-monitor Signed-off-by: Junya Sasaki <[email protected]>
* Inconsistent namespacings * Wrongly updated copyrights * Missing dependencies Signed-off-by: Junya Sasaki <[email protected]>
* Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <[email protected]>
* To follow the previous commit Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
…f github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-system-monitor Signed-off-by: Junya Sasaki <[email protected]>
github-actions
bot
added
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Directory Name
autoware_as a prefix to the directory name.packages.xml
autoware_to thenameelement.CMakeLists.txt
projectname toautoware_***.autoware::toPLUGIN.Header Files (.hpp)
#ifndefguards withAUTOWARE__.autoware::tonamespace.Source Files (.cpp)
autoware::insideRCLCPP_COMPONENTS_REGISTER_NODE.Launch Files
autoware_beforefind-pkg-share.node pkg="<pkgname>"toautoware_<pkgname>.Include
autowarefolder as necessary and update include statements accordingly.Verification Points
find-pkg-sharein autowaresensor_launchas seen ingnss_poserNotes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
system_monitorneeds to modify their code. This is maybe kind of non quick-win task.