-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_radar_tracks_noise_filter): Created Schema file and updated ReadME file for parameters setting #9992
Conversation
…ings Signed-off-by: vish0012 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9992 +/- ##
=======================================
Coverage 29.76% 29.77%
=======================================
Files 1444 1444
Lines 108686 108671 -15
Branches 42664 42661 -3
=======================================
Hits 32352 32352
+ Misses 73150 73135 -15
Partials 3184 3184
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for your contribution. Can you check the json schema to pass this test? Additionally, can you test if the document is generated in your local environment by following this guide? |
… as per review comments Signed-off-by: vish0012 <[email protected]>
|
Thank you for the fix. Can you test if the document is generated in your local environment by following the guide https://autowarefoundation.github.io/autoware-documentation/main/contributing/documentation-guidelines/#2-running-an-mkdocs-server-in-your-local-environment? |
Updated README File
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated README File
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tings
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_radar_tracks_noise_filter package.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.