Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_radar_tracks_noise_filter): Created Schema file and updated ReadME file for parameters setting #9992

Conversation

vish0012
Copy link
Contributor

…tings

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_radar_tracks_noise_filter package.

  • create json shema
  • update readme file

Related links

Parent Issue:

  • Link

How was this PR tested?

  • colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_radar_tracks_noise_filter
  • ros2 launch launch/radar_tracks_noise_filter.launch.xml

Screenshot from 2025-01-21 09-47-43
Screenshot from 2025-01-21 09-44-42

  • Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vish0012 vish0012 changed the title feat: Created Schema file and updated ReadME file for parameters set… feat(autoware_radar_tracks_noise_filter): Created Schema file and updated ReadME file for parameters setting Jan 21, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.77%. Comparing base (ddfacd3) to head (7ea82b0).
Report is 292 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9992   +/-   ##
=======================================
  Coverage   29.76%   29.77%           
=======================================
  Files        1444     1444           
  Lines      108686   108671   -15     
  Branches    42664    42661    -3     
=======================================
  Hits        32352    32352           
+ Misses      73150    73135   -15     
  Partials     3184     3184           
Flag Coverage Δ *Carryforward flag
differential 61.53% <ø> (?)
differential-cuda 61.53% <ø> (?)
total 29.77% <ø> (+<0.01%) ⬆️ Carriedforward from 62d2230

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin
Copy link
Contributor

technolojin commented Jan 21, 2025

@vish0012

Thank you for your contribution.

Screenshot from 2025-01-21 11-38-04

Can you check the json schema to pass this test?

Additionally, can you test if the document is generated in your local environment by following this guide?

@technolojin technolojin self-assigned this Jan 21, 2025
@vish0012
Copy link
Contributor Author

@vish0012

Thank you for your contribution.

Screenshot from 2025-01-21 11-38-04

Can you check the json schema to pass this test?

Additionally, can you test if the document is generated in your local environment by following this guide?

@technolojin san thank you for comments i try to update the schema file and run , but now showing this i am attaching the screen shot for reference.
Screenshot from 2025-01-28 11-54-24

@technolojin
Copy link
Contributor

Thank you for the fix.

Can you test if the document is generated in your local environment by following the guide https://autowarefoundation.github.io/autoware-documentation/main/contributing/documentation-guidelines/#2-running-an-mkdocs-server-in-your-local-environment?
Screenshot of the new document page would be enough.

Updated README File
Copy link
Contributor Author

@vish0012 vish0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated README File

@vish0012
Copy link
Contributor Author

vish0012 commented Feb 3, 2025

Thank you for the fix.

Can you test if the document is generated in your local environment by following the guide https://autowarefoundation.github.io/autoware-documentation/main/contributing/documentation-guidelines/#2-running-an-mkdocs-server-in-your-local-environment? Screenshot of the new document page would be enough.

@technolojin Thank you for your valuable guidance and feedback. I have set up the local environment following the provided guide and am attaching a screenshot for your reference.

Screenshot from 2025-02-03 11-58-57

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin enabled auto-merge (squash) February 4, 2025 07:38
@technolojin technolojin merged commit 9d965fb into autowarefoundation:main Feb 4, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants