-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): support remote multi-platform compilation on ci #5204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! But the CIs were failed. Please pass them then I will review this.
https://github.com/autowarefoundation/autoware/actions/runs/10777587669
cf30ad4
to
e56d4c3
Compare
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
b244385
to
e1ef328
Compare
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Updated the PR to its latest state and here is the test run, it can now build If it will not exceed the 6 hours limit of standart job execution time than it will produce multi-architecture images on a single workflow run. If it exceeds the job execution time then we have only two options remaining to achieve multi-architecture images: |
@oguzkaganozt It seems like pre-commit is failing. Could you fix your PR so that it passes the CI? (you can also test locally by running Also your test seems to be failing as well. |
After investigating the need of combined workflows which eventually leads to 6-hour runtime constraint on github runners, I am suggesting this solution which will produce the similar result without the need for upgrades. |
Description
Support remote
multi-platform compilation
in order to push images in a single manifest with multiple architectures.Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/10828791104
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.