Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): add autoware prefix to map_loader #5451

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Nov 18, 2024

Description

Fixes the build error after merging autowarefoundation/autoware.universe#8927

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/11892785154

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@oguzkaganozt oguzkaganozt added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Nov 18, 2024
@oguzkaganozt oguzkaganozt self-assigned this Nov 18, 2024
@oguzkaganozt oguzkaganozt requested a review from xmfcx November 18, 2024 12:50
@youtalk youtalk added the tag:run-health-check Run health-check label Nov 18, 2024
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@oguzkaganozt oguzkaganozt enabled auto-merge (squash) November 18, 2024 12:56
@oguzkaganozt oguzkaganozt merged commit 0dd0883 into main Nov 18, 2024
32 checks passed
@oguzkaganozt oguzkaganozt deleted the fix-map-loader-name-dockerfile branch November 18, 2024 13:49
youtalk added a commit that referenced this pull request Nov 19, 2024
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants