Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): minor update tier4/awsim_sensor_kit_launch to v0.40.0 #5585

Conversation

awf-autoware-bot[bot]
Copy link
Contributor

Description

This PR updates the version of the repository tier4/awsim_sensor_kit_launch in autoware.repos.

What's changed

You can see the changes in tier4/awsim_sensor_kit_launch@0.39.0...v0.40.0.

Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtk8532704 Please rename the tag.
https://github.com/tier4/awsim_sensor_kit_launch/releases/tag/v0.40.0

@sasakisasaki It’s not ideal for the release bot to operate even with these naming convention differences.

@@ -107,7 +107,7 @@ repositories:
sensor_kit/external/awsim_sensor_kit_launch: # TODO: Integrate into sample_sensor_kit_launch
type: git
url: https://github.com/tier4/awsim_sensor_kit_launch.git
version: 0.39.0
version: v0.40.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v prefix version is not acceptable.

Copy link

@xtk8532704 xtk8532704 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction. I will close this PR and fix them.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youtalk Thank you for detecting the bug. Let me investigate!

@xtk8532704 xtk8532704 closed this Dec 20, 2024
@youtalk youtalk deleted the feat/update-tier4/awsim_sensor_kit_launch/v0.40.0 branch December 20, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants