Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-build-and-push): push universe-visualization images to ghcr.io #5690

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 24, 2025

Description

In #5679, the image push destination for universe-visualization was mistakenly set to docker.io because my forked repo uses docker.io. https://hub.docker.com/r/youtalk/autoware/tags

https://github.com/autowarefoundation/autoware/actions/runs/12920581839/job/36033142078#step:6:41068

This PR corrects it to ghcr.io.

How was this PR tested?

https://github.com/autowarefoundation/autoware/actions/runs/12944782709

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from oguzkaganozt as a code owner January 24, 2025 06:57
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Jan 24, 2025
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Jan 24, 2025
@youtalk youtalk merged commit bcc4f18 into main Jan 27, 2025
40 of 42 checks passed
@youtalk youtalk deleted the fix/use-ghcr-io branch January 27, 2025 00:03
@esteve
Copy link
Contributor

esteve commented Jan 27, 2025

@youtalk thanks! I missed that when I reviewed #5679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants