Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-prs-to-update-vcs-repositories.yaml): target only major and minor version updates for simulator.repos #5698

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 27, 2025

Description

The version updates for scenario_simulator_v2 are significantly faster compared to other repositories, which often leads to an accumulation of PRs created by the release bot.

https://github.com/autowarefoundation/autoware/pulls?q=is%3Apr+update+tier4%2Fscenario_simulator_v2

To address this, the version updates in simulator.repos will be limited to major and minor updates only.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@youtalk youtalk requested a review from oguzkaganozt as a code owner January 27, 2025 04:13
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Jan 27, 2025
@youtalk youtalk added tag:run-health-check Run health-check component:simulation Virtual environment setups and simulations. labels Jan 27, 2025
Copy link
Collaborator

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick Comment

Good to me!

Reason for Approval

This PR makes sense in the following reasons:

  • The PR was created for every frequent patch update (in our repository's case this might be a little bit noisy)
  • For our case, it is fine to check for every >= minor updates
  • The workflow has been tested in this PR

@youtalk youtalk merged commit 3c15855 into main Jan 27, 2025
32 checks passed
@youtalk youtalk deleted the youtalk-patch-1 branch January 27, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants