Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant cmake definition #13

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jul 1, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.93%. Comparing base (a586d15) to head (203b61a).
Report is 1 commits behind head on main.

Current head 203b61a differs from pull request most recent head 01df65c

Please upload reports for the commit 01df65c to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   15.93%   15.93%           
=======================================
  Files          40       40           
  Lines        2748     2748           
  Branches     1339     1340    +1     
=======================================
  Hits          438      438           
  Misses       2222     2222           
  Partials       88       88           
Flag Coverage Δ
differential 15.93% <ø> (ø)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But we need to fix the cpplint problem https://results.pre-commit.ci/run/github/791833089/1719813784.vF-W1qiuSbyweopfbpNS9Q.
@wep21 Could you fix them?

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 LGTM, thanks. Optionally, if you want, you can move the header files to the src folder and keep them private if there are no downstream packages that depend on these headers.

@youtalk youtalk enabled auto-merge (squash) July 2, 2024 05:39
@youtalk
Copy link
Member

youtalk commented Jul 2, 2024

LGTM But we need to fix the cpplint problem https://results.pre-commit.ci/run/github/791833089/1719813784.vF-W1qiuSbyweopfbpNS9Q. @wep21 Could you fix them?

This was solved by #15.

@youtalk youtalk merged commit 406a86a into autowarefoundation:main Jul 2, 2024
12 checks passed
@wep21 wep21 deleted the refactor-cmake branch July 2, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants