Add policy statement to s3VPCE to allow pulling from docker hub #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-compose pulls the client images from docker hub. The s3VPC needs to allow those actions. Otherwise the pulls fail with HTTP 403 and the images don't get pulled. Adding the policy statement to the VPCE fixes this and allows pulling from docker hub.
|
Not for review: the relevant lines are 81–88, the other lines are formatting changes. |
frbrkoala
pushed a commit
that referenced
this pull request
Feb 29, 2024
* ha nodes and update testing * Add sample config and uncomment common stacks test. * include autofixes from pre-commit procedure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR opens the s3VPCE for
docker pullcommands, which fails otherwise.docker-composepulls the client images from docker hub. The s3VPC needs to allow those actions. Otherwise the pulls fail with HTTP 403 and the images don't get pulled. Adding the policy statement to the VPCE fixes this and allows pulling from docker hub.The solution is adapted from another issue: Cannot pull images from dockerhub (403 Access Denied)
Motivation
The 'erigion-lighthouse' configuration did not work without it.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes