Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy statement to s3VPCE to allow pulling from docker hub #3

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Add policy statement to s3VPCE to allow pulling from docker hub #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c1142c
Add policy statement to s3VPCE to allow pulling from docker hub
cniemanAWS Oct 12, 2023
eaf7bc9
Fix formatting via pre-commit
cniemanAWS Oct 12, 2023
b3e6016
Remove unchanged file from commit
cniemanAWS Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 50 additions & 31 deletions lib/ethereum/lib/common-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as cdk from "aws-cdk-lib";
import * as cdkConstructs from "constructs";
import * as ec2 from "aws-cdk-lib/aws-ec2";
import * as iam from 'aws-cdk-lib/aws-iam';
import * as iam from "aws-cdk-lib/aws-iam";
import * as nag from "cdk-nag";
import * as s3Assets from "aws-cdk-lib/aws-s3-assets";
import * as path from "path";
Expand All @@ -24,11 +24,11 @@ export class EthCommonStack extends cdk.Stack {

const snapshotsBucket = new SnapshotsS3BucketConstruct(this, `snapshots-s3-bucket`, {
bucketName: `eth-snapshots-${this.AWS_ACCOUNT_ID}-${this.AWS_STACKNAME}`,
});
});

const s3VPCEndpoint = vpc.addGatewayEndpoint('s3-vpc-endpoint', {
const s3VPCEndpoint = vpc.addGatewayEndpoint("s3-vpc-endpoint", {
service: ec2.GatewayVpcEndpointAwsService.S3,
})
});

const instanceRole = new iam.Role(this, `node-role`, {
assumedBy: new iam.ServicePrincipal("ec2.amazonaws.com"),
Expand All @@ -38,35 +38,54 @@ export class EthCommonStack extends cdk.Stack {
],
});

instanceRole.addToPolicy(new iam.PolicyStatement({
// Can't target specific stack: https://github.com/aws/aws-cdk/issues/22657
resources: ["*"],
actions: ["cloudformation:SignalResource"],
}));

instanceRole.addToPolicy(new iam.PolicyStatement({
resources: [`arn:aws:autoscaling:${region}:${this.AWS_ACCOUNT_ID}:autoScalingGroup:*:autoScalingGroupName/eth-*`],
actions: ["autoscaling:CompleteLifecycleAction"],
}));

instanceRole.addToPolicy(new iam.PolicyStatement({
resources: [snapshotsBucket.bucketArn, snapshotsBucket.arnForObjects("*")],
actions: ["s3:ListBucket", "s3:*Object"],
}));
instanceRole.addToPolicy(
new iam.PolicyStatement({
// Can't target specific stack: https://github.com/aws/aws-cdk/issues/22657
resources: ["*"],
actions: ["cloudformation:SignalResource"],
})
);

instanceRole.addToPolicy(
new iam.PolicyStatement({
resources: [
`arn:aws:autoscaling:${region}:${this.AWS_ACCOUNT_ID}:autoScalingGroup:*:autoScalingGroupName/eth-*`,
],
actions: ["autoscaling:CompleteLifecycleAction"],
})
);

instanceRole.addToPolicy(
new iam.PolicyStatement({
resources: [snapshotsBucket.bucketArn, snapshotsBucket.arnForObjects("*")],
actions: ["s3:ListBucket", "s3:*Object"],
})
);

// Limiting access through this VPC endpoint only to our sync bucket and Amazon linux repo bucket
s3VPCEndpoint.addToPolicy(new iam.PolicyStatement({
principals: [new iam.AnyPrincipal()],
resources: [
snapshotsBucket.bucketArn,
snapshotsBucket.arnForObjects("*"),
`arn:aws:s3:::amazonlinux-2-repos-${region}`,
`arn:aws:s3:::amazonlinux-2-repos-${region}/*`,
`arn:aws:s3:::${asset.s3BucketName}`,
`arn:aws:s3:::${asset.s3BucketName}/*`,
],
actions: ["s3:ListBucket", "s3:*Object", "s3:GetBucket*"],
}));
s3VPCEndpoint.addToPolicy(
new iam.PolicyStatement({
principals: [new iam.AnyPrincipal()],
resources: [
snapshotsBucket.bucketArn,
snapshotsBucket.arnForObjects("*"),
`arn:aws:s3:::amazonlinux-2-repos-${region}`,
`arn:aws:s3:::amazonlinux-2-repos-${region}/*`,
`arn:aws:s3:::${asset.s3BucketName}`,
`arn:aws:s3:::${asset.s3BucketName}/*`,
],
actions: ["s3:ListBucket", "s3:*Object", "s3:GetBucket*"],
})
);

s3VPCEndpoint.addToPolicy(
new iam.PolicyStatement({
principals: [new iam.AnyPrincipal()],
resources: ["arn:aws:s3:::docker-images-prod", "arn:aws:s3:::docker-images-prod/*"],
actions: ["*"],
sid: "Allow access to docker images",
})
);

new cdk.CfnOutput(this, "Instance Role ARN", {
value: instanceRole.roleArn,
Expand Down
Loading