Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudwatch-metrics chart to allow env vars to passed in #1090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

charlierm
Copy link

Issue

Description of changes

This adds the ability to pass in additional environment variables into the cloudwatch-agent daemonset. This is particuarly useful for using RUN_WITH_IRSA.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

I ran this locally, testing different environment variables, bools, strings and numbers all seem to work as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants