Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloudwatch-metrics chart to allow env vars to passed in #1090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update cloudwatch-metrics chart to allow env vars to passed in #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/aws-cloudwatch-metrics/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: aws-cloudwatch-metrics
description: A Helm chart to deploy aws-cloudwatch-metrics project
version: 0.0.11
version: 0.0.12
appVersion: "1.300032.2b361"
home: https://github.com/aws/eks-charts
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
Expand Down
1 change: 1 addition & 0 deletions stable/aws-cloudwatch-metrics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ helm upgrade --install aws-cloudwatch-metrics \
| `image.repository` | Image to deploy | `amazon/cloudwatch-agent` | ✔
| `image.tag` | Image tag to deploy | `1.247345.36b249270`
| `image.pullPolicy` | Pull policy for the image | `IfNotPresent` | ✔
| `env` | Environment variables to be passed for the daemonset | {} |
| `clusterName` | Name of your cluster | `cluster_name` | ✔
| `enhancedContainerInsights` | EKS cluster with enhanced monitoring | `true` |
| `serviceAccount.create` | Whether a new service account should be created | `true` |
Expand Down
4 changes: 4 additions & 0 deletions stable/aws-cloudwatch-metrics/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ spec:
{{- include "aws-cloudwatch-metrics.statsdConfig" . | nindent 8 -}}
# Please don't change below envs
env:
{{- range $key, $value := .Values.env }}
- name: {{ $key }}
value: {{ $value | quote }}
{{- end }}
- name: HOST_IP
valueFrom:
fieldRef:
Expand Down
2 changes: 2 additions & 0 deletions stable/aws-cloudwatch-metrics/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ clusterName: cluster_name
enhancedContainerInsights:
enabled: true

env: {}

resources:
limits:
cpu: 200m
Expand Down