Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Cloudprovider interface with driftReason #4397

Merged
merged 1 commit into from
Aug 9, 2023
Merged

chore: Update Cloudprovider interface with driftReason #4397

merged 1 commit into from
Aug 9, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 7, 2023

Fixes #N/A

Description

  • Bumping karpetner-core version and passing drift reason to karpenter-core

How was this change tested?

  • make battletest
  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8b884db
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64d2e497de3b7000080a5a97

@engedaam engedaam force-pushed the isMachineDrifted_update branch 4 times, most recently from 0244385 to 95f03f4 Compare August 8, 2023 17:56
@engedaam engedaam marked this pull request as ready for review August 8, 2023 17:56
@engedaam engedaam requested a review from a team as a code owner August 8, 2023 17:56
@engedaam engedaam requested a review from tzneal August 8, 2023 17:56
engedaam
engedaam commented Aug 8, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-95f03f4755c5fb1333fa6093f276de619006c410. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

njtran
njtran reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits on replacing the "" with the enum.

pkg/cloudprovider/cloudprovider.go Show resolved Hide resolved
pkg/cloudprovider/drift.go Show resolved Hide resolved
pkg/fake/cloudprovider.go Show resolved Hide resolved
@engedaam engedaam force-pushed the isMachineDrifted_update branch 3 times, most recently from ec7f14e to 7fa06fa Compare August 8, 2023 18:58
engedaam
engedaam commented Aug 8, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-7fa06fabca7f19b6209f8838ff50be5406fc8b97. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@engedaam engedaam force-pushed the isMachineDrifted_update branch 2 times, most recently from d92c728 to 7b0ceb4 Compare August 9, 2023 00:13
jonathan-innis
jonathan-innis reviewed Aug 9, 2023
View reviewed changes
pkg/cloudprovider/cloudprovider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/cloudprovider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/suite_test.go Outdated Show resolved Hide resolved
pkg/cloudprovider/drift.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@engedaam engedaam force-pushed the isMachineDrifted_update branch 3 times, most recently from ea7d884 to b7d7ff8 Compare August 9, 2023 00:35
jonathan-innis
jonathan-innis approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) August 9, 2023 01:04
@engedaam engedaam merged commit e658971 into aws:main Aug 9, 2023
12 checks passed
@engedaam engedaam deleted the isMachineDrifted_update branch August 9, 2023 01:07
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Aug 9, 2023
@engedaam @jonathan-innis
chore: Update Cloudprovider interface with driftReason (aws#4397)
b918dbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @njtran @jonathan-innis