feat: Add Versioned for EC2NodeClass Hash to Prevent Drift on EC2NodeClass CRD Upgrade #5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
engedaam
force-pushed
the
versioned-hash
branch
2 times, most recently
from
8595ac8
to
fcc97cf
Compare
Pull Request Test Coverage Report for Build 8253246984Details
💛 - Coveralls |
engedaam
force-pushed
the
versioned-hash
branch
4 times, most recently
from
63c81ef
to
8a4a9f5
Compare
njtran
reviewed
Mar 5, 2024
engedaam
force-pushed
the
versioned-hash
branch
4 times, most recently
from
db723d1
to
1b7b223
Compare
engedaam
force-pushed
the
versioned-hash
branch
6 times, most recently
from
65c5050
to
0fca6bd
Compare
engedaam
force-pushed
the
versioned-hash
branch
7 times, most recently
from
0d13e86
to
edc833e
Compare
engedaam
force-pushed
the
versioned-hash
branch
7 times, most recently
from
c55145b
to
5f87834
Compare
Co-authored-by: Jonathan Innis <[email protected]>
engedaam
force-pushed
the
versioned-hash
branch
from
5f87834
to
f33b96b
Compare
engedaam
force-pushed
the
versioned-hash
branch
2 times, most recently
from
3d7d154
to
4d374e4
Compare
engedaam
force-pushed
the
versioned-hash
branch
from
4d374e4
to
473e723
Compare
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 25, 2024
…Class CRD Upgrade (aws#5770)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 25, 2024
…Class CRD Upgrade (aws#5770)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 25, 2024
…Class CRD Upgrade (aws#5770)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 25, 2024
…Class CRD Upgrade (aws#5770)
This was referenced Mar 25, 2024
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
…Class CRD Upgrade (aws#5770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Add versioned NodePool Hash to prevent Drift from occurring under these scenario:
EC2NodeClassadds default values to existing fields that are included in the hash calculationsEC2NodeClassfield is added to the hash calculation with an already-set valueEC2NodeClassfield is removed from the hash calculationsRFC: kubernetes-sigs/karpenter#1015
Related Issue: kubernetes-sigs/karpenter#957
How was this change tested?
make presubmitDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.