Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add E2E tests for NodePools Hash Version #5803

Merged
merged 1 commit into from
Mar 12, 2024
Merged

test: Add E2E tests for NodePools Hash Version #5803

merged 1 commit into from
Mar 12, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Mar 7, 2024 •
edited
Loading

Fixes #N/A

Description

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner March 7, 2024 21:46
@engedaam engedaam requested a review from jigisha620 March 7, 2024 21:46
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0ee08c2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65f08c54193eea00079ddc8f

@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8252952936

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.743%
Totals Coverage Status
Change from base Build 8245150615: 0.02%
Covered Lines: 5303
Relevant Lines: 6409
💛 - Coveralls

@engedaam engedaam force-pushed the nodepool-version-e2e branch 5 times, most recently from b60b791 to 8162546 Compare March 7, 2024 23:47
jonathan-innis
jonathan-innis reviewed Mar 8, 2024
View reviewed changes
test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
test/suites/drift/suite_test.go Show resolved Hide resolved
test/suites/drift/suite_test.go Show resolved Hide resolved
@engedaam engedaam force-pushed the nodepool-version-e2e branch 8 times, most recently from 5895f3f to ecc065c Compare March 12, 2024 16:50
jonathan-innis
jonathan-innis previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) March 12, 2024 17:13
jonathan-innis
jonathan-innis approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit cf9b9b3 into aws:main Mar 12, 2024
16 checks passed
@engedaam engedaam deleted the nodepool-version-e2e branch March 13, 2024 01:48
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 25, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (aws#5803)
f13820c
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 25, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (aws#5803)
e908fb6
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 25, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (aws#5803)
66068fb
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 25, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (aws#5803)
7baa4f8
This was referenced Mar 25, 2024
Merged
Merged
Merged
Merged
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 26, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (aws#5803)
4fcb110
engedaam added a commit that referenced this pull request Mar 26, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (#5803)
9212589
engedaam added a commit that referenced this pull request Mar 26, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (#5803)
e03dfff
engedaam added a commit that referenced this pull request Mar 26, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (#5803)
4dba10f
engedaam added a commit that referenced this pull request Mar 26, 2024
@engedaam
test: Add E2E tests for NodePools Hash Version (#5803)
85dca5a
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@engedaam @johngmyers
test: Add E2E tests for NodePools Hash Version (aws#5803)
8c950b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jigisha620 jigisha620 Awaiting requested review from jigisha620 jigisha620 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis