Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add unit cache tests for LaunchTemplate #6006

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Apr 9, 2024

Fixes #N/A

Description

  • Adding testing to validate the LaunchTemplate cache key is generated as expected

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 9, 2024 15:15
@engedaam engedaam requested a review from jmdeal April 9, 2024 15:15
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8496e0a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66156e272022c4000919929e

@engedaam engedaam force-pushed the cache-launch-template-testing branch 2 times, most recently from 44005e5 to 49501d6 Compare April 9, 2024 15:16
@coveralls
Copy link

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8619209984

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.246%

Totals Coverage Status
Change from base Build 8619115889: 0.0%
Covered Lines: 5332
Relevant Lines: 6483

💛 - Coveralls

@engedaam engedaam force-pushed the cache-launch-template-testing branch from 49501d6 to 8496e0a Compare April 9, 2024 16:34
@engedaam engedaam enabled auto-merge (squash) April 9, 2024 16:35
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit e5f6262 into aws:main Apr 9, 2024
17 checks passed
@engedaam engedaam deleted the cache-launch-template-testing branch April 14, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants