Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add unit cache tests for LaunchTemplate #6006

Merged
merged 1 commit into from
Apr 9, 2024
Merged

test: Add unit cache tests for LaunchTemplate #6006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/providers/launchtemplate/launchtemplate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func (p *DefaultProvider) InvalidateCache(ctx context.Context, ltName string, lt
p.cache.Delete(ltName)
}

func launchTemplateName(options *amifamily.LaunchTemplate) string {
func LaunchTemplateName(options *amifamily.LaunchTemplate) string {
hash, err := hashstructure.Hash(options, hashstructure.FormatV2, &hashstructure.HashOptions{SlicesAsSets: true})
if err != nil {
panic(fmt.Sprintf("hashing launch template, %s", err))
Expand Down Expand Up @@ -215,7 +215,7 @@ func (p *DefaultProvider) createAMIOptions(ctx context.Context, nodeClass *v1bet

func (p *DefaultProvider) ensureLaunchTemplate(ctx context.Context, options *amifamily.LaunchTemplate) (*ec2.LaunchTemplate, error) {
var launchTemplate *ec2.LaunchTemplate
name := launchTemplateName(options)
name := LaunchTemplateName(options)
ctx = logging.WithLogger(ctx, logging.FromContext(ctx).With("launch-template-name", name))
// Read from cache
if launchTemplate, ok := p.cache.Get(name); ok {
Expand Down Expand Up @@ -260,7 +260,7 @@ func (p *DefaultProvider) createLaunchTemplate(ctx context.Context, options *ami
}
networkInterfaces := p.generateNetworkInterfaces(options)
output, err := p.ec2api.CreateLaunchTemplateWithContext(ctx, &ec2.CreateLaunchTemplateInput{
LaunchTemplateName: aws.String(launchTemplateName(options)),
LaunchTemplateName: aws.String(LaunchTemplateName(options)),
LaunchTemplateData: &ec2.RequestLaunchTemplateData{
BlockDeviceMappings: p.blockDeviceMappings(options.BlockDeviceMappings),
IamInstanceProfile: &ec2.LaunchTemplateIamInstanceProfileSpecificationRequest{
Expand Down
105 changes: 105 additions & 0 deletions pkg/providers/launchtemplate/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import (
"sigs.k8s.io/yaml"

corev1beta1 "sigs.k8s.io/karpenter/pkg/apis/v1beta1"
corecloudprovider "sigs.k8s.io/karpenter/pkg/cloudprovider"
"sigs.k8s.io/karpenter/pkg/controllers/provisioning"
"sigs.k8s.io/karpenter/pkg/controllers/state"
"sigs.k8s.io/karpenter/pkg/events"
Expand All @@ -62,6 +63,7 @@ import (
"github.com/aws/karpenter-provider-aws/pkg/providers/amifamily/bootstrap"
"github.com/aws/karpenter-provider-aws/pkg/providers/amifamily/bootstrap/mime"
"github.com/aws/karpenter-provider-aws/pkg/providers/instancetype"
"github.com/aws/karpenter-provider-aws/pkg/providers/launchtemplate"
"github.com/aws/karpenter-provider-aws/pkg/test"
)

Expand Down Expand Up @@ -318,6 +320,109 @@ var _ = Describe("LaunchTemplate Provider", func() {
Expect(awsEnv.EC2API.CreateFleetBehavior.SuccessfulCalls()).To(BeNumerically("==", 2))

})
// Testing launch template hash key will produce unique hashes
It("should generate different launch template names based on amifamily option configuration", func() {
options := []*amifamily.Options{
{},
{ClusterName: "test-name"},
{ClusterEndpoint: "test-endpoint"},
{ClusterCIDR: lo.ToPtr("test-cidr")},
{InstanceProfile: "test-profile"},
{InstanceStorePolicy: lo.ToPtr(v1beta1.InstanceStorePolicyRAID0)},
{SecurityGroups: []v1beta1.SecurityGroup{{Name: "test-sg"}}},
{Tags: map[string]string{"test-key": "test-value"}},
{KubeDNSIP: net.ParseIP("192.0.0.2")},
{AssociatePublicIPAddress: lo.ToPtr(true)},
{NodeClassName: "test-name"},
}
launchtemplateResult := []string{}
for _, option := range options {
lt := &amifamily.LaunchTemplate{Options: option}
launchtemplateResult = append(launchtemplateResult, launchtemplate.LaunchTemplateName(lt))
}
Expect(len(launchtemplateResult)).To(BeNumerically("==", 11))
Expect(lo.Uniq(launchtemplateResult)).To(Equal(launchtemplateResult))
})
It("should not generate different launch template names based on CABundle and Labels", func() {
options := []*amifamily.Options{
{},
{CABundle: lo.ToPtr("test-bundle")},
{Labels: map[string]string{"test-key": "test-value"}},
}
launchtemplateResult := []string{}
for _, option := range options {
lt := &amifamily.LaunchTemplate{Options: option}
launchtemplateResult = append(launchtemplateResult, launchtemplate.LaunchTemplateName(lt))
}
Expect(len(lo.Uniq(launchtemplateResult))).To(BeNumerically("==", 1))
Expect(lo.Uniq(launchtemplateResult)[0]).To(Equal(launchtemplate.LaunchTemplateName(&amifamily.LaunchTemplate{Options: &amifamily.Options{}})))
})
It("should generate different launch template names based on kubelet configuration", func() {
kubeletChanges := []*corev1beta1.KubeletConfiguration{
{},
{KubeReserved: map[string]string{string(v1.ResourceCPU): "20"}},
{SystemReserved: map[string]string{string(v1.ResourceMemory): "10Gi"}},
{EvictionHard: map[string]string{"memory.available": "52%"}},
{EvictionSoft: map[string]string{"nodefs.available": "132%"}},
{MaxPods: aws.Int32(20)},
}
launchtemplateResult := []string{}
for _, kubelet := range kubeletChanges {
lt := &amifamily.LaunchTemplate{UserData: bootstrap.EKS{Options: bootstrap.Options{KubeletConfig: kubelet}}}
launchtemplateResult = append(launchtemplateResult, launchtemplate.LaunchTemplateName(lt))
}
Expect(len(launchtemplateResult)).To(BeNumerically("==", 6))
Expect(lo.Uniq(launchtemplateResult)).To(Equal(launchtemplateResult))
})
It("should generate different launch template names based on bootstrap configuration", func() {
bootstrapOptions := []*bootstrap.Options{
{},
{ClusterName: "test-name"},
{ClusterEndpoint: "test-endpoint"},
{ClusterCIDR: lo.ToPtr("test-cidr")},
{Taints: []v1.Taint{{Key: "test-key", Value: "test-value"}}},
{Labels: map[string]string{"test-key": "test-value"}},
{CABundle: lo.ToPtr("test-bundle")},
{AWSENILimitedPodDensity: true},
{ContainerRuntime: lo.ToPtr("test-cri")},
{CustomUserData: lo.ToPtr("test-cidr")},
}
launchtemplateResult := []string{}
for _, option := range bootstrapOptions {
lt := &amifamily.LaunchTemplate{UserData: bootstrap.EKS{Options: *option}}
launchtemplateResult = append(launchtemplateResult, launchtemplate.LaunchTemplateName(lt))
}
Expect(len(launchtemplateResult)).To(BeNumerically("==", 10))
Expect(lo.Uniq(launchtemplateResult)).To(Equal(launchtemplateResult))
})
It("should generate different launch template names based on launchtemplate option configuration", func() {
launchtemplates := []*amifamily.LaunchTemplate{
{},
{BlockDeviceMappings: []*v1beta1.BlockDeviceMapping{{DeviceName: lo.ToPtr("test-block")}}},
{AMIID: "test-ami"},
{DetailedMonitoring: true},
{EFACount: 12},
{CapacityType: "spot"},
}
launchtemplateResult := []string{}
for _, lt := range launchtemplates {
launchtemplateResult = append(launchtemplateResult, launchtemplate.LaunchTemplateName(lt))
}
Expect(len(launchtemplateResult)).To(BeNumerically("==", 6))
Expect(lo.Uniq(launchtemplateResult)).To(Equal(launchtemplateResult))
})
It("should not generate different launch template names based on instance types", func() {
launchtemplates := []*amifamily.LaunchTemplate{
{},
{InstanceTypes: []*corecloudprovider.InstanceType{{Name: "test-instance-type"}}},
}
launchtemplateResult := []string{}
for _, lt := range launchtemplates {
launchtemplateResult = append(launchtemplateResult, launchtemplate.LaunchTemplateName(lt))
}
Expect(len(lo.Uniq(launchtemplateResult))).To(BeNumerically("==", 1))
Expect(lo.Uniq(launchtemplateResult)[0]).To(Equal(launchtemplate.LaunchTemplateName(&amifamily.LaunchTemplate{})))
})
})
Context("Labels", func() {
It("should apply labels to the node", func() {
Expand Down
Loading