Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update scale test for expiration to not update expireAfter to p… #6732

Merged
merged 1 commit into from
Aug 13, 2024
Merged

test: Update scale test for expiration to not update expireAfter to p… #6732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/suites/scale/deprovisioning_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,8 @@ var _ = Describe("Deprovisioning", Label(debug.NoWatch), Label(debug.NoEvents),
nodeClass.Spec.Kubelet = &v1.KubeletConfiguration{
MaxPods: lo.ToPtr[int32](int32(maxPodDensity)),
}
// Enable Expiration
nodePool.Spec.Template.Spec.ExpireAfter = karpv1.MustParseNillableDuration("5m")

By("waiting for the deployment to deploy all of its pods")
env.ExpectCreated(deployment)
Expand Down Expand Up @@ -616,8 +618,6 @@ var _ = Describe("Deprovisioning", Label(debug.NoWatch), Label(debug.NoEvents),
By("kicking off deprovisioning expiration by setting the ttlSecondsUntilExpired value on the nodePool")
// Change limits so that replacement nodes will use another nodePool.
nodePool.Spec.Limits = disableProvisioningLimits
// Enable Expiration
nodePool.Spec.Template.Spec.ExpireAfter.Duration = lo.ToPtr(time.Duration(0))

noExpireNodePool := test.NodePool(*nodePool.DeepCopy())

Expand Down
Loading