test: Update scale test for expiration to not update expireAfter to p… #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 10378598609Details
💛 - Coveralls |
engedaam
reviewed
Aug 13, 2024
engedaam
reviewed
Aug 13, 2024
jigisha620
force-pushed
the
fix-scale-tests
branch
from
ffb1980
to
4193a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…revent drift
Fixes #N/A
Description
Scale tests for expiration is taking longer since we moved expireAfter under nodeclaim spec template which causes drift if this value is updated. This PR sets expireAfter to a suitable value(time we expect all nodes will take to register) thus triggering expiration.
How was this change tested?
Tested on local cluster
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.