-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new acore_string editor #3210
Conversation
imports: [TranslateModule, ReactiveFormsModule, TooltipModule, QueryOutputComponent, TopBarComponent], | ||
}) | ||
export class AcoreStringComponent extends SingleRowEditorComponent<AcoreString> { | ||
override readonly editorService = inject(AcoreStringService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since Angular 14 we can access protected
attributes also from the template, so there is very rarely a reason to use public
and when we don't it's just because it's old code :)
override readonly editorService = inject(AcoreStringService); | |
protected override readonly editorService = inject(AcoreStringService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change causes this error:
TS2415: Class AcoreStringComponent incorrectly extends base class SingleRowEditorComponent
Property editorService is protected in type AcoreStringComponent but public in type SingleRowEditorComponent<AcoreString
And changing the editor causes a follow up issue.
IMO; this is a separate problem to be addressed
libs/features/texts/src/acore-text/select-acore-string.component.html
Outdated
Show resolved
Hide resolved
libs/features/texts/src/acore-text/select-acore-string.component.ts
Outdated
Show resolved
Hide resolved
libs/features/texts/src/acore-text/select-acore-string.integration.spec.ts
Outdated
Show resolved
Hide resolved
libs/features/texts/src/acore-text/select-acore-string.integration.spec.ts
Outdated
Show resolved
Hide resolved
libs/features/texts/src/acore-text/acore-string.integration.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code looks very good! Thank you very much for this contribution. I've just left a couple of minor suggestions here and there. I hope I will have some time soon to test this PR and then we can merge it! <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the bug of the sidebar by using the correct handler service
Adds a new editor for the acore_string table for the section "Other texts".
I realized yesterday that there isn't an editor or at least search field for this table and decided to implement it.