Convert editorService from public to protected #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helias
approved these changes
Dec 21, 2024
| @@ -87,7 +87,7 @@ import { EditorButtonsComponent, QueryOutputComponent } from '@keira/shared/base | |||
| ], | |||
| }) | |||
| export class SaiEditorComponent extends MultiRowEditorComponent<SmartScripts> implements OnInit { | |||
| override readonly editorService = inject(SaiEditorService); | |||
| public override readonly editorService = inject(SaiEditorService); | |||
There was a problem hiding this comment.
we should define a codestyle about writing public, I personally don't write the code that is unnecessary, but I see that there is no consistency in Keira3 @FrancescoBorzi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here the editor in components can be made protected.
This PR does that for all currently available editors.
I hope that this change is helpful