Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert editorService from public to protected #3212

Merged
merged 1 commit into from
Dec 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ import { TooltipModule } from 'ngx-bootstrap/tooltip';
],
})
export class CreatureEquipTemplateComponent extends SingleRowEditorComponent<CreatureEquipTemplate> {
override readonly editorService = inject(CreatureEquipTemplateService);
protected override readonly editorService = inject(CreatureEquipTemplateService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ import { CreatureLootTemplateService } from './creature-loot-template.service';
imports: [TopBarComponent, LootEditorComponent],
})
export class CreatureLootTemplateComponent extends LootTemplateIdComponent<CreatureLootTemplate> {
override readonly editorService = inject(CreatureLootTemplateService);
protected override readonly editorService = inject(CreatureLootTemplateService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ import { CreatureOnkillReputationService } from './creature-onkill-reputation.se
export class CreatureOnkillReputationComponent extends SingleRowEditorComponent<CreatureOnkillReputation> {
readonly FACTION_RANK = FACTION_RANK;

override readonly editorService = inject(CreatureOnkillReputationService);
protected override readonly editorService = inject(CreatureOnkillReputationService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ import { CreatureQuestitemService } from './creature-questitem.service';
],
})
export class CreatureQuestitemComponent extends MultiRowEditorComponent<CreatureQuestitem> {
override readonly editorService = inject(CreatureQuestitemService);
protected override readonly editorService = inject(CreatureQuestitemService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ export class CreatureSpawnAddonComponent extends MultiRowEditorComponent<Creatur
readonly CREATURE_ADDON_BYTES_1 = CREATURE_ADDON_BYTES_1;
readonly CREATURE_ADDON_BYTES_2 = CREATURE_ADDON_BYTES_2;

override readonly editorService = inject(CreatureSpawnAddonService);
protected override readonly editorService = inject(CreatureSpawnAddonService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ export class CreatureSpawnComponent extends MultiRowEditorComponent<CreatureSpaw
readonly SPAWN_MASK = SPAWN_MASK;
readonly PHASE_MASK = PHASE_MASK;

override readonly editorService = inject(CreatureSpawnService);
protected override readonly editorService = inject(CreatureSpawnService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ export class CreatureTemplateAddonComponent extends SingleRowEditorComponent<Cre
protected readonly CREATURE_ADDON_BYTES_1 = CREATURE_ADDON_BYTES_1;
protected readonly CREATURE_ADDON_BYTES_2 = CREATURE_ADDON_BYTES_2;

override readonly editorService = inject(CreatureTemplateAddonService);
protected override readonly editorService = inject(CreatureTemplateAddonService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { CreatureTemplateModelService } from './creature-template-model.service'
],
})
export class CreatureTemplateModelComponent extends MultiRowEditorComponent<CreatureTemplateModel> {
override readonly editorService = inject(CreatureTemplateModelService);
protected override readonly editorService = inject(CreatureTemplateModelService);
readonly handlerService = inject(CreatureHandlerService);

protected readonly NPC_VIEWER_TYPE = VIEWER_TYPE.NPC;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ export class CreatureTemplateMovementComponent extends SingleRowEditorComponent<
return this.WIKI_BASE_URL + CREATURE_TEMPLATE_MOVEMENT_TABLE;
}

override readonly editorService = inject(CreatureTemplateMovementService);
protected override readonly editorService = inject(CreatureTemplateMovementService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ export class CreatureTemplateResistanceComponent extends MultiRowEditorComponent

protected readonly CREATURE_TEMPLATE_RESISTANCE_SCHOOL = CREATURE_TEMPLATE_RESISTANCE_SCHOOL;

override readonly editorService = inject(CreatureTemplateResistanceService);
protected override readonly editorService = inject(CreatureTemplateResistanceService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class CreatureTemplateSpellComponent extends MultiRowEditorComponent<Crea

protected readonly SPELL_INDEXES = [0, 1, 2, 3, 4, 5, 6, 7];

override readonly editorService = inject(CreatureTemplateSpellService);
protected override readonly editorService = inject(CreatureTemplateSpellService);
readonly handlerService = inject(CreatureHandlerService);
readonly sqliteQueryService = inject(SqliteQueryService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,6 @@ export class CreatureTemplateComponent extends SingleRowEditorComponent<Creature
protected RACE_ICON_GENDER = true;
protected showCreaturePreview = false;

override readonly editorService = inject(CreatureTemplateService);
protected override readonly editorService = inject(CreatureTemplateService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ export class CreatureTextComponent extends MultiRowEditorComponent<CreatureText>
protected readonly TEXT_RANGE = TEXT_RANGE;
protected readonly EMOTE = EMOTE;

public override readonly editorService = inject(CreatureTextService);
protected override readonly editorService = inject(CreatureTextService);
protected override readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { NpcTrainerService } from './npc-trainer.service';
],
})
export class NpcTrainerComponent extends MultiRowEditorComponent<NpcTrainer> {
override readonly editorService = inject(NpcTrainerService);
protected override readonly editorService = inject(NpcTrainerService);
readonly handlerService = inject(CreatureHandlerService);
readonly sqliteQueryService = inject(SqliteQueryService);
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, LootEditorComponent],
})
export class PickpocketingLootTemplateComponent extends LootTemplateIdComponent<PickpocketingLootTemplate> {
override readonly editorService = inject(PickpocketingLootTemplateService);
protected override readonly editorService = inject(PickpocketingLootTemplateService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, LootEditorComponent],
})
export class SkinningLootTemplateComponent extends LootTemplateIdComponent<SkinningLootTemplate> {
override readonly editorService = inject(SkinningLootTemplateService);
protected override readonly editorService = inject(SkinningLootTemplateService);
readonly handlerService = inject(CreatureHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class GameobjectLootTemplateComponent extends LootTemplateIdComponent<Gam
);
}

override readonly editorService = inject(GameobjectLootTemplateService);
protected override readonly editorService = inject(GameobjectLootTemplateService);
readonly handlerService = inject(GameobjectHandlerService);

override ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ import { GameobjectQuestitemService } from './gameobject-questitem.service';
],
})
export class GameobjectQuestitemComponent extends MultiRowEditorComponent<GameobjectQuestitem> {
override readonly editorService = inject(GameobjectQuestitemService);
protected override readonly editorService = inject(GameobjectQuestitemService);
readonly handlerService = inject(GameobjectHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ import { GameobjectSpawnAddonService } from './gameobject-spawn-addon.service';
export class GameobjectSpawnAddonComponent extends MultiRowEditorComponent<GameobjectSpawnAddon> {
readonly INVISIBILITY_TYPE = INVISIBILITY_TYPE;

override readonly editorService = inject(GameobjectSpawnAddonService);
protected override readonly editorService = inject(GameobjectSpawnAddonService);
readonly handlerService = inject(GameobjectHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ export class GameobjectSpawnComponent extends MultiRowEditorComponent<Gameobject
readonly SPAWN_MASK = SPAWN_MASK;
readonly PHASE_MASK = PHASE_MASK;

override readonly editorService = inject(GameobjectSpawnService);
protected override readonly editorService = inject(GameobjectSpawnService);
readonly handlerService = inject(GameobjectHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ import { GameobjectTemplateAddonService } from './gameobject-template-addon.serv
export class GameobjectTemplateAddonComponent extends SingleRowEditorComponent<GameobjectTemplateAddon> {
readonly GAMEOBJECT_FLAGS = GAMEOBJECT_FLAGS;

override readonly editorService = inject(GameobjectTemplateAddonService);
protected override readonly editorService = inject(GameobjectTemplateAddonService);
readonly handlerService = inject(GameobjectHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class GameobjectTemplateComponent extends SingleRowEditorComponent<Gameob

showGameobjectPreview = true;

override readonly editorService = inject(GameobjectTemplateService);
protected override readonly editorService = inject(GameobjectTemplateService);
readonly handlerService = inject(GameobjectHandlerService);

dataFieldDefinition(dataIndex: number): FieldDefinition {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class GossipMenuOptionComponent extends MultiRowEditorComponent<GossipMen
readonly OPTION_ICON = OPTION_ICON;
readonly OPTION_TYPE = OPTION_TYPE;

override readonly editorService = inject(GossipMenuOptionService);
protected override readonly editorService = inject(GossipMenuOptionService);
readonly handlerService = inject(GossipHandlerService);

showGossipPreview = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { GossipMenuService } from './gossip-menu.service';
],
})
export class GossipMenuComponent extends MultiRowEditorComponent<GossipMenu> {
override readonly editorService = inject(GossipMenuService);
protected override readonly editorService = inject(GossipMenuService);
readonly handlerService = inject(GossipHandlerService);
readonly queryService = inject(MysqlQueryService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ import { TranslateModule } from '@ngx-translate/core';
],
})
export class ItemEnchantmentTemplateComponent extends MultiRowEditorComponent<ItemEnchantmentTemplate> {
override readonly editorService = inject(ItemEnchantmentTemplateService);
protected override readonly editorService = inject(ItemEnchantmentTemplateService);
readonly handlerService = inject(ItemHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ import { ItemLootTemplateService } from './item-loot-template.service';
imports: [TopBarComponent, LootEditorComponent],
})
export class ItemLootTemplateComponent extends LootTemplateComponent<ItemLootTemplate> {
override readonly editorService = inject(ItemLootTemplateService);
protected override readonly editorService = inject(ItemLootTemplateService);
readonly handlerService = inject(ItemHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ import { ItemTemplateService } from './item-template.service';
],
})
export class ItemTemplateComponent extends SingleRowEditorComponent<ItemTemplate> implements OnInit {
override readonly editorService = inject(ItemTemplateService);
protected override readonly editorService = inject(ItemTemplateService);
readonly handlerService = inject(ItemHandlerService);
private readonly itemPreviewService = inject(ItemPreviewService);
private readonly sanitizer = inject(DomSanitizer);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, LootEditorComponent],
})
export class MillingLootTemplateComponent extends LootTemplateComponent<MillingLootTemplate> {
override readonly editorService = inject(MillingLootTemplateService);
protected override readonly editorService = inject(MillingLootTemplateService);
readonly handlerService = inject(ItemHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, LootEditorComponent],
})
export class ProspectingLootTemplateComponent extends LootTemplateComponent<ProspectingLootTemplate> {
override readonly editorService = inject(ProspectingLootTemplateService);
protected override readonly editorService = inject(ProspectingLootTemplateService);
readonly handlerService = inject(ItemHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, TranslateModule, LootEditorComponent],
})
export class FishingLootTemplateComponent extends LootTemplateComponent<FishingLootTemplate> {
override readonly editorService = inject(FishingLootTemplateService);
protected override readonly editorService = inject(FishingLootTemplateService);
readonly handlerService = inject(FishingLootHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, TranslateModule, LootEditorComponent],
})
export class MailLootTemplateComponent extends LootTemplateComponent<MailLootTemplate> {
override readonly editorService = inject(MailLootTemplateService);
protected override readonly editorService = inject(MailLootTemplateService);
readonly handlerService = inject(MailLootHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ import { TopBarComponent } from '@keira/shared/base-editor-components';
imports: [TopBarComponent, TranslateModule, LootEditorComponent],
})
export class ReferenceLootTemplateComponent extends LootTemplateComponent<ReferenceLootTemplate> {
override readonly editorService = inject(ReferenceLootTemplateService);
protected override readonly editorService = inject(ReferenceLootTemplateService);
readonly handlerService = inject(ReferenceLootHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ import { LootEditorComponent } from '@keira/shared/loot-editor';
imports: [TopBarComponent, TranslateModule, LootEditorComponent],
})
export class SpellLootTemplateComponent extends LootTemplateComponent<SpellLootTemplate> {
override readonly editorService = inject(SpellLootTemplateService);
protected override readonly editorService = inject(SpellLootTemplateService);
readonly handlerService = inject(SpellLootHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { CreatureQuestenderService } from './creature-questender.service';
],
})
export class CreatureQuestenderComponent extends MultiRowEditorComponent<CreatureQuestender> {
override readonly editorService = inject(CreatureQuestenderService);
protected override readonly editorService = inject(CreatureQuestenderService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { CreatureQueststarterService } from './creature-queststarter.service';
],
})
export class CreatureQueststarterComponent extends MultiRowEditorComponent<CreatureQueststarter> {
override readonly editorService = inject(CreatureQueststarterService);
protected override readonly editorService = inject(CreatureQueststarterService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { GameobjectQuestenderService } from './gameobject-questender.service';
],
})
export class GameobjectQuestenderComponent extends MultiRowEditorComponent<GameobjectQuestender> {
override readonly editorService = inject(GameobjectQuestenderService);
protected override readonly editorService = inject(GameobjectQuestenderService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { GameobjectQueststarterService } from './gameobject-queststarter.service
],
})
export class GameobjectQueststarterComponent extends MultiRowEditorComponent<GameobjectQueststarter> {
override readonly editorService = inject(GameobjectQueststarterService);
protected override readonly editorService = inject(GameobjectQueststarterService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { QuestOfferRewardService } from './quest-offer-reward.service';
export class QuestOfferRewardComponent extends SingleRowEditorComponent<QuestOfferReward> {
readonly EMOTE = EMOTE;

override readonly editorService = inject(QuestOfferRewardService);
protected override readonly editorService = inject(QuestOfferRewardService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { QuestRequestItemsService } from './quest-request-items.service';
],
})
export class QuestRequestItemsComponent extends SingleRowEditorComponent<QuestRequestItems> {
override readonly editorService = inject(QuestRequestItemsService);
protected override readonly editorService = inject(QuestRequestItemsService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import { QuestTemplateAddonService } from './quest-template-addon.service';
],
})
export class QuestTemplateAddonComponent extends SingleRowEditorComponent<QuestTemplateAddon> {
override readonly editorService = inject(QuestTemplateAddonService);
protected override readonly editorService = inject(QuestTemplateAddonService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import { QuestTemplateService } from './quest-template.service';
],
})
export class QuestTemplateComponent extends SingleRowEditorComponent<QuestTemplate> {
override readonly editorService = inject(QuestTemplateService);
protected override readonly editorService = inject(QuestTemplateService);
readonly handlerService = inject(QuestHandlerService);
readonly questPreviewService = inject(QuestPreviewService);

Expand Down
2 changes: 1 addition & 1 deletion libs/features/spell/src/spell-dbc/spell-dbc.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ import { QueryOutputComponent, TopBarComponent } from '@keira/shared/base-editor
],
})
export class SpellDbcComponent extends SingleRowEditorComponent<SpellDbc> {
override readonly editorService = inject(SpellDbcService);
protected override readonly editorService = inject(SpellDbcService);
readonly handlerService = inject(SpellHandlerService);
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { BroadcastTextService } from './broadcast-text.service';
],
})
export class BroadcastTextComponent extends SingleRowEditorComponent<BroadcastText> {
override readonly editorService = inject(BroadcastTextService);
protected override readonly editorService = inject(BroadcastTextService);
protected override readonly handlerService = inject(BroadcastTextHandlerService);

protected readonly EMOTE = EMOTE;
Expand Down
2 changes: 1 addition & 1 deletion libs/features/texts/src/npc-text/npc-text.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ import { NpcTextFieldsGroupComponent } from './npc-text-fields-group.component';
],
})
export class NpcTextComponent extends SingleRowEditorComponent<NpcText> {
override readonly editorService = inject(NpcTextService);
protected override readonly editorService = inject(NpcTextService);
protected override readonly handlerService = inject(NpcTextHandlerService);
}
2 changes: 1 addition & 1 deletion libs/features/texts/src/page-text/page-text.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ import { PageText } from '@keira/shared/acore-world-model';
],
})
export class PageTextComponent extends SingleRowEditorComponent<PageText> {
override readonly editorService = inject(PageTextService);
protected override readonly editorService = inject(PageTextService);
protected override readonly handlerService = inject(PageTextHandlerService);
}
Loading